Project

General

Profile

Actions

Bug #17866

open

Incompatible changes with Psych 4.0.0

Added by hsbt (Hiroshi SHIBATA) 7 months ago. Updated 7 months ago.

Status:
Assigned
Priority:
Normal
Target version:
-
[ruby-core:103866]

Description

Psych-4.0.0 changes Psych.safe_load by the default.

https://github.com/ruby/psych/pull/487

It breaks the several code like:

I and mame (Yusuke Endoh) investigate them. We found 2 issues.

  1. Symbol is still ignored Pysch.load. It break many of code like configuration store. https://github.com/ruby/psych/blob/master/lib/psych.rb#L368 passes Symbol used by permitted_classes. But It's not working now. see https://github.com/ruby/psych/issues/490
  2. Pysch.load restrict Gem::Specification or RDoc::Options by the default. Should we add them withpermitted_classes to Psych.load or Psych.load_file? I'm not sure the right way about them.

tenderlovemaking (Aaron Patterson) Do you have any ideas about the above concerns?

Actions

Also available in: Atom PDF