Project

General

Profile

Feature #13381

[PATCH] Expose rb_fstring and its family to C extensions

Added by eagletmt (Kohei Suzuki) over 2 years ago. Updated about 2 years ago.

Status:
Assigned
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:80447]

History

#1

Updated by ko1 (Koichi Sasada) over 2 years ago

  • Status changed from Open to Feedback

I can understand use cases but we shouldn't expose the name "fstring".

Updated by eagletmt (Kohei Suzuki) over 2 years ago

OK, I've read comments of #13077.

What do you think of renaming fstring to "deduped" string? "Deduped" strings are implicitly frozen.

  • Rename rb_fstring to rb_str_deduped
  • Rename rb_fstring_new to rb_str_deduped_new
  • Rename rb_fstring_cstr to rb_str_deduped_cstr
  • Rename rb_fstring_enc_new to rb_enc_str_deduped_new
  • Rename rb_fstring_enc_cstr to rb_enc_str_deduped_cstr
    • I think enc should come first for consistency

Updated by ko1 (Koichi Sasada) about 2 years ago

  • Assignee set to ko1 (Koichi Sasada)
  • Status changed from Feedback to Assigned

Updated by nobu (Nobuyoshi Nakada) about 2 years ago

  • Assignee deleted (ko1 (Koichi Sasada))

How about fixed_str?

Also available in: Atom PDF