Project

General

Profile

Actions

Bug #3351

closed

stack overflow on super

Added by serge_balyuk (Serge Balyuk) almost 12 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Target version:
-
ruby -v:
ruby 1.9.3dev (2010-05-26 trunk 28028) [i686-linux]
Backport:
[ruby-core:30450]

Description

It looks like super behavior is a bit different in 1.8 and 1.9. Please find the example below:

 class Base
   def foo
     puts "bar"
   end
 end
 
 module Override
   def foo
     puts "override"
     super
   end
 end
 
 
 class A < Base
 end
 
 class B < A
 end
 
 B.send(:include, Override)
 A.send(:include, Override)
 
 B.new.foo
 
 ruby 1.8.7 (2009-06-12 patchlevel 174) [i486-linux] output:
 
 
 override
 override
 bar

and ruby 1.9.3dev (2010-05-26 trunk 28028) [i686-linux] output:

 ....
 override
 override
 override
 override
 override
 super.rb:9: stack level too deep (SystemStackError)

Hope that helps.


Files

super.rb (217 Bytes) super.rb serge_balyuk (Serge Balyuk), 05/27/2010 03:45 PM

Related issues 3 (0 open3 closed)

Related to Ruby master - Bug #2502: strange behavior of anonymous class inside a procClosedko1 (Koichi Sasada)12/19/2009Actions
Related to Ruby master - Bug #5236: Including a module in a superclass after it has been included in a subclass leads to infinite recursion if the module uses `super`Closednobu (Nobuyoshi Nakada)08/27/2011Actions
Related to Ruby master - Feature #1586: Including a module already present in ancestors should not be ignoredRejectedmatz (Yukihiro Matsumoto)Actions
Actions #1

Updated by marcandre (Marc-Andre Lafortune) almost 12 years ago

  • Category set to core
  • Priority changed from Normal to 3

I thought I had submitted that bug, actually, but seems I forgot!

Just to clarify: this happens when a module appears twice in the list of ancestors. Ruby typically forbids this, but if the module is included in just the right order, it is possible. In the example given, invert the two includes and Override is included only once.

Actions #2

Updated by serge_balyuk (Serge Balyuk) almost 12 years ago

Hi Marc-Andre,

Yes, exactly. Very rare situation. This is the simplified version of include sequence that I observed in one specific rails/rspec use case. And with inverted includes everything works like charm.

Thanks

Updated by naruse (Yui NARUSE) almost 11 years ago

  • Status changed from Open to Assigned
  • Assignee set to ko1 (Koichi Sasada)
  • Target version changed from 2.0.0 to 1.9.3

Updated by funny_falcon (Yura Sokolov) almost 11 years ago

I had catched by this with rails/sequel/custom backend for delayed_jobs.
After figuring, I ought to do some manipulations with requiring my initializators, and that looks ugly a bit.

Updated by ko1 (Koichi Sasada) almost 11 years ago

  • Target version changed from 1.9.3 to 2.0.0

I'll challenge this issue on 1.9.4. Sorry.

Actions #6

Updated by shugo (Shugo Maeda) almost 10 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r36612.
Serge, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • insns.def (invokesuper): don't skip the same class. instead, use
    rb_method_entry_get_with_omod() to avoid infinite loop when
    super is used with refinements. [ruby-core:30450] [Bug #3351]

Updated by shugo (Shugo Maeda) almost 10 years ago

  • Status changed from Closed to Open

In HEAD of trunk, stack overflow doesn't occur, but Override#foo is called only once.
So I reopen this ticket.

Updated by ko1 (Koichi Sasada) over 9 years ago

shugo-san, do you know why Override#foo called only once?

Updated by mame (Yusuke Endoh) over 9 years ago

  • Status changed from Open to Assigned
  • Assignee changed from ko1 (Koichi Sasada) to shugo (Shugo Maeda)

Shugo-san, ko1, what's the status?
Do you think this issue important?

--
Yusuke Endoh

Updated by shugo (Shugo Maeda) over 9 years ago

  • Assignee changed from shugo (Shugo Maeda) to matz (Yukihiro Matsumoto)

mame (Yusuke Endoh) wrote:

Shugo-san, ko1, what's the status?

Override#foo is called only once, because in the SVN trunk, if a method found by super is the current method, it's skipped to avoid an infinite loop. The check was introduced for super in a refinement. Without it, super in a refinement causes an infinite loop.

Do you think this issue important?

I don't think so. Can I leave it as is, Matz?

Updated by Anonymous over 9 years ago

Hi,

In message "Re: [ruby-core:50857] [ruby-trunk - Bug #3351] stack overflow on super"
on Thu, 13 Dec 2012 14:24:21 +0900, "shugo (Shugo Maeda)" writes:

Do you think this issue important?

I don't think so. Can I leave it as is, Matz?

OK.

						matz.

Updated by shugo (Shugo Maeda) over 9 years ago

  • Status changed from Assigned to Open
  • Assignee deleted (matz (Yukihiro Matsumoto))
  • Target version changed from 2.0.0 to 2.6

Updated by ko1 (Koichi Sasada) about 9 years ago

  • Assignee set to ko1 (Koichi Sasada)

Updated by ko1 (Koichi Sasada) almost 7 years ago

  • Description updated (diff)

Updated by ko1 (Koichi Sasada) almost 7 years ago

Just now, we avoid this issue by putting klass into each frame.

However, the workaround is remaining.

Now, ancestors is here:

[B, Override, A, Override, Base, Object, Kernel, BasicObject]

and now MRI calls Override#foo only once. It skips second Override#foo.

override
bar

However, if there is a A#foo, then call Override#foo twice.

override
A
override
bar

It is ugly workaround. So I want to remove such skipping.

Matz: Can I call Override#foo twice even if it is duplicated with last call?

Actions #17

Updated by ko1 (Koichi Sasada) almost 7 years ago

  • Status changed from Open to Closed

Applied in changeset r51161.


  • vm_insnhelper.c (vm_search_super_method): do not skip calling
    same methods in super.
    [Bug #3351]
  • test/ruby/test_super.rb: fix a test.
Actions

Also available in: Atom PDF