Bug #10436: ruby -c and ripper inconsistency: m(&nil) {}

• Status: Closed
• Assignee: -
• Target version: -
• ruby -v: ruby 2.2.0dev (2014-10-27 trunk 48168) [x86_64-linux]
• Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
• Tags: patch, ext

[akr (Akira Tanaka)]

m(&nil) {} というまちがったコードは
ruby -c でちゃんとエラーになるのに、
Ripper.sexp ではならないようです。

% cat z.rb 
m(&nil) {}
% ruby -c z.rb 
z.rb:1: both block arg and actual block given
% ruby -rripper -e 'p Ripper.sexp(STDIN.read)' < z.rb
[:program, [[:method_add_block, [:method_add_arg, [:fcall, [:@ident, "m", [1, 0]]], [:arg_paren, [:args_add_block, [], [:var_ref, [:@kw, "nil", [1, 3]]]]]], [:brace_block, nil, [[:void_stmt]]]]]]
% ruby -v
ruby 2.2.0dev (2014-10-27 trunk 48168) [x86_64-linux]

[jeremyevans0 (Jeremy Evans)]

• File ripper-block_dup_check-10436.patch ripper-block_dup_check-10436.patch added

This bug still occurs in the master branch. Attached is a patch that fixes the problem by overriding Ripper::SexpBuilder#on_method_add_block. This isn't a very clean way to fix it, but I was not able to figure out a way to fix it by modifying parse.y.

[nobu (Nobuyoshi Nakada)]

I'm overhauling ripper to multiplex the callback values and the parser union.
https://github.com/nobu/ruby/tree/ripper.value

[mame (Yusuke Endoh)]

• Related to Feature #18831: Block argument to `yield` added

[jemmai (Jemma Issroff)]

This bug still exists on Ripper. Should we try revive @jeremyevans0's patch?

It is potentially worth noting that Prism creates a ParseError: "Multiple block arguments; only one block is allowed"

[yui-knk (Kaneko Yuichiro)]

• Status changed from Open to Closed

This is solved by https://bugs.ruby-lang.org/issues/20257 (https://github.com/ruby/ruby/pull/9923).