Project

General

Profile

Actions

Bug #10436

closed

ruby -c and ripper inconsistency: m(&nil) {}

Added by akr (Akira Tanaka) over 9 years ago. Updated 28 days ago.

Status:
Closed
Assignee:
-
Target version:
-
ruby -v:
ruby 2.2.0dev (2014-10-27 trunk 48168) [x86_64-linux]
[ruby-dev:<unknown>]
Tags:

Description

m(&nil) {} というまちがったコードは
ruby -c でちゃんとエラーになるのに、
Ripper.sexp ではならないようです。

% cat z.rb 
m(&nil) {}
% ruby -c z.rb 
z.rb:1: both block arg and actual block given
% ruby -rripper -e 'p Ripper.sexp(STDIN.read)' < z.rb
[:program, [[:method_add_block, [:method_add_arg, [:fcall, [:@ident, "m", [1, 0]]], [:arg_paren, [:args_add_block, [], [:var_ref, [:@kw, "nil", [1, 3]]]]]], [:brace_block, nil, [[:void_stmt]]]]]]
% ruby -v
ruby 2.2.0dev (2014-10-27 trunk 48168) [x86_64-linux]

Files

ripper-block_dup_check-10436.patch (2.2 KB) ripper-block_dup_check-10436.patch jeremyevans0 (Jeremy Evans), 08/21/2019 03:48 AM

Related issues 1 (1 open0 closed)

Related to Ruby master - Feature #18831: Block argument to `yield`OpenActions
Actions #1

Updated by jeremyevans0 (Jeremy Evans) over 4 years ago

This bug still occurs in the master branch. Attached is a patch that fixes the problem by overriding Ripper::SexpBuilder#on_method_add_block. This isn't a very clean way to fix it, but I was not able to figure out a way to fix it by modifying parse.y.

Updated by nobu (Nobuyoshi Nakada) over 4 years ago

I'm overhauling ripper to multiplex the callback values and the parser union.
https://github.com/nobu/ruby/tree/ripper.value

Actions #3

Updated by mame (Yusuke Endoh) almost 2 years ago

Updated by jemmai (Jemma Issroff) 4 months ago

This bug still exists on Ripper. Should we try revive @jeremyevans0's patch?

It is potentially worth noting that Prism creates a ParseError: "Multiple block arguments; only one block is allowed"

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0