Feature #5096: offer Logger-compatibility for syslog ext

• Status: Closed
• Assignee: knu (Akinori MUSHA)
• Target version: -

[normalperson (Eric Wong)]

There's http://rubygems.org/gems/SyslogLogger, but I would like to have
ths compatibility by default. Having to remember to install the
oddly-capitalized SyslogLogger gem makes things harder than it should
be.

Importing the SyslogLogger gem would solve this issue.

[normalperson (Eric Wong)]

Bah, I submitted the bug before I finished typing :<

Title should be: "offer Logger-compatibility for syslog ext"
Priority should be: Low

There's http://rubygems.org/gems/SyslogLogger, but I would like to have
ths compatibility by default. Having to remember to install the
oddly-capitalized SyslogLogger gem makes things harder than it should
be.

Importing the SyslogLogger gem would solve this issue.

[nahi (Hiroshi Nakamura)]

• Subject changed from offer Logger-compatibility for ext to offer Logger-compatibility for syslog ext
• Priority changed from Normal to 3

[drbrain (Eric Hodel)]

I would be happy to import my SyslogLogger gem, but I need someone to decide if it is ok first.

[naruse (Yui NARUSE)]

Where is a patch or the repository?

Anyway such enhancement should be introduced as a patch to trunk.
We are hard to understand the actual change of this feature.

Moreover adding a new library or replacing a library is hard to accepted.
Enhance a existed library is much easier then it.

[drbrain (Eric Hodel)]

• Assignee set to drbrain (Eric Hodel)

The repository is here: https://github.com/seattlerb/sysloglogger

I will attach a patch to this issue soon.

[tenderlovemaking (Aaron Patterson)]

• File sysloglogger.patch sysloglogger.patch added

I've attached a patch. It imports sysloglogger as Syslog::Logger. Syslog::Logger is a logger that logs to Syslog, but has the same API as Logger.

[drbrain (Eric Hodel)]

I think the implementation is fine, but the Syslog::Logger constant should be updated since the name was changed.

Also, should the rails references be removed or changed?

[drbrain (Eric Hodel)]

Ugh, I meant "Syslog::Logger comment"

[shyouhei (Shyouhei Urabe)]

• Status changed from Open to Assigned

[drbrain (Eric Hodel)]

• File syslog.logger.patch syslog.logger.patch added

This updated patch removes references to rails and the silence method (as it is not thread-safe).

[knu (Akinori MUSHA)]

• Assignee changed from drbrain (Eric Hodel) to knu (Akinori MUSHA)

I'll look into this shortly.

I think I'm going to put this under ext/syslog/lib/syslog/ so the whole syslog library can be made a gem in the future.

[drbrain (Eric Hodel)]

The second rails-free patch places it under ext/syslog/lib/syslog and introduces test/syslog/.

I did not move test/test_syslog.rb to test/syslog/test_syslog.rb though, I was going to submit this as a separate issue if this was was accepted.

[knu (Akinori MUSHA)]

Oh, of course. I didn't carefully read the latest patch.

I've revised the implementation and the tests as attached.

Here's the list of what I changed:

• Reduced map constants. You shouldn't need this many.

• Changed Syslog::Logger::SYSLOG to Syslog::Logger.syslog using a class variable as storage. I didn't like the way the constant was used.

• Changed to call syslog methods with ('%s', message) instead of manually replacing %'s.

• Changed a regexp so it exactly matches (ANSI & XTerm) color escape sequences.

Please merge it if it's OK, and you have my approval.

[drbrain (Eric Hodel)]

I think you forgot to attach the patch.

Your changes sound good, thank you for the review and update on my very (5 year) old code.

[knu (Akinori MUSHA)]

• File knu-syslog_logger.patch.txt knu-syslog_logger.patch.txt added

[knu (Akinori MUSHA)]

D'oh, here it is.

[drbrain (Eric Hodel)]

• Status changed from Assigned to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r35682.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

• ext/syslog/lib/syslog/logger.rb: Added Syslog::Logger which was
  ported from the SyslogLogger gem. [ruby-trunk - Feature #5096]
• NEWS: ditto.
• test/syslog/test_syslog_logger.rb: ditto.