General

Profile

normalperson (Eric Wong)

Issues

Projects

Activity

01/08/2019

06:22 PM Ruby trunk Bug #15499: Breaking behavior on ruby 2.6: rb_thread_call_without_gvl doesn't invoke unblock_function when used on the main thread
> Issue #15499 has been updated by dentarg (Patrik Ragnarsson).

Patrik: can you try r66708? (git 9e66910b3bd85de3...
normalperson (Eric Wong)

01/04/2019

02:52 PM Ruby trunk Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
me@dmitry.it wrote:
> Eric, FYI, something is wrong with native threads on osx in this update(though I'm not sure i...
normalperson (Eric Wong)
01:22 PM Ruby trunk Bug #15499: Breaking behavior on ruby 2.6: rb_thread_call_without_gvl doesn't invoke unblock_function when used on the main thread
Eric Wong <normalperson@yhbt.net> wrote:
> apolcyn@google.com wrote:
> > Thanks for the quick look! I didn't get a...
normalperson (Eric Wong)
01:22 PM Ruby trunk Bug #15499 (Assigned): Breaking behavior on ruby 2.6: rb_thread_call_without_gvl doesn't invoke unblock_function when used on the main thread
ko1: can you check the rb_nogvl C-API introduced in r66712?
Thanks.
normalperson (Eric Wong)
12:53 PM Ruby trunk Bug #15499 (Closed): Breaking behavior on ruby 2.6: rb_thread_call_without_gvl doesn't invoke unblock_function when used on the main thread
Applied in changeset trunk|r66708.
----------
thread.c (call_without_gvl): spawn thread for UBF iff single-threaded
...
normalperson (Eric Wong)
01:14 PM Ruby trunk Revision 66712 (trunk): introduce rb_nogvl C-API to mark ubf as async-signal-safe
zlib and bignum both contain unblocking functions which are
async-signal-safe and do not require spawning additional
...
normalperson (Eric Wong)
12:53 PM Ruby trunk Revision 66708 (trunk): thread.c (call_without_gvl): spawn thread for UBF iff single-threaded
We need another native thread to call some unblocking functions
which aren't RUBY_UBF_IO or RUBY_UBF_PROCESS. Instea...
normalperson (Eric Wong)

01/03/2019

10:42 PM Ruby trunk Bug #15499: Breaking behavior on ruby 2.6: rb_thread_call_without_gvl doesn't invoke unblock_function when used on the main thread
apolcyn@google.com wrote:
> Thanks for the quick look! I didn't get a chance to try out
> UBF_TIMER=2 before your ...
normalperson (Eric Wong)
09:03 AM Ruby trunk Bug #15499: Breaking behavior on ruby 2.6: rb_thread_call_without_gvl doesn't invoke unblock_function when used on the main thread
> Can you try compiling with "cppflags=-DUBF_TIMER=2" ?

Nevermind, both need fixing...
normalperson (Eric Wong)
02:03 AM Ruby trunk Bug #15499: Breaking behavior on ruby 2.6: rb_thread_call_without_gvl doesn't invoke unblock_function when used on the main thread
> https://bugs.ruby-lang.org/issues/15499

Probably my fault with timer-thread elimination :<

I think we'll nee...
normalperson (Eric Wong)

Also available in: Atom