Feature #18571
closedRemoved the bundled sources from release package after Ruby 3.2
Description
We shipped release package with the 3rd party source for mswin environment especially.
The current status is here:
- libyaml: psych gem, ruby repo and package always bundled it.
- libffi: only ruby package bundled it. fiddle gem and repo are not bundled.
- zlib: gem, ruby repo and package don't bundled.
I propose we stop bundling the third-party source for security and maintenance reasons. Because we have vcpkg for mswin environment today. So, vcpkg provides the runtime for psych, fiddle and zlib.
Updated by mame (Yusuke Endoh) over 2 years ago
@tenderlovemaking's comment for psych and libffi: https://github.com/ruby/psych/issues/535
Updated by hsbt (Hiroshi SHIBATA) over 2 years ago
- Status changed from Open to Assigned
- Assignee set to hsbt (Hiroshi SHIBATA)
We decided on the following policy.
- We will remove the bundled sources from ruby repo.
- @hsbt (Hiroshi SHIBATA) is working now for psych and fiddle.
- If users put the third-party source under the ruby packages, ruby build system use them.
Updated by matz (Yukihiro Matsumoto) over 2 years ago
Accepted, for the record.
Matz.
Updated by hsbt (Hiroshi SHIBATA) over 2 years ago
- Related to Bug #18666: No rule to make target 'yaml/yaml.h', needed by 'api.o' added
Updated by nobu (Nobuyoshi Nakada) over 2 years ago
- Status changed from Assigned to Closed
Applied in changeset git|282baa694320bbe385693902dfde0bdf93a532b8.
[DOC] Move the entry for [Feature #18571]
Updated by hsbt (Hiroshi SHIBATA) over 2 years ago
- Status changed from Closed to Assigned
Updated by hsbt (Hiroshi SHIBATA) about 2 years ago
The current distributed package still contained libyaml and libffi sources.
We will remove them and introduce the instructions to download them when building ruby like ./configure --enable-download-source
.
Updated by hsbt (Hiroshi SHIBATA) about 2 years ago
e4f5296f065110fa83eb450d3a861253e76e534f removed them.
Updated by hsbt (Hiroshi SHIBATA) about 2 years ago
- Related to Bug #18790: cannot load such file -- digest (LoadError) added
Updated by hsbt (Hiroshi SHIBATA) about 2 years ago
- Related to Bug #18034: Segmentation fault fiddle with `--enable-bundled-libffi` and macOS added
Updated by hsbt (Hiroshi SHIBATA) about 2 years ago
I and nobu added --with-xxx-source-dir
option for psych and fiddle instead of --enable-bundled-libyaml
.
The users who want to use newer version of libyaml or libffi environment can use this option like gem install psych -- --with-libyaml-source-dir=$(pwd)/libyaml-0.2.5
.
Updated by hsbt (Hiroshi SHIBATA) almost 2 years ago
- Target version set to 3.2
We should add the additional options and instructions to document or NEWS.
Updated by hsbt (Hiroshi SHIBATA) almost 2 years ago
- Status changed from Assigned to Closed
I added build instructions with new options at https://github.com/ruby/ruby/commit/a80b66e7ebf1179964b416cee6fd236048a73dcf