Bug #17850: `PAGE_SIZE` is no longer a constant for macOS

• Status: Closed
• Assignee: peterzhu2118 (Peter Zhu)
• Target version: -
• Backport: 2.6: DONTNEED, 2.7: DONTNEED, 3.0: DONTNEED

[xtkoba (Tee KOBAYASHI)]

Build failure for macOS Big Sur (ARM) due to -Wundef (#17752).

It is said in https://www.wwdcnotes.com/notes/wwdc20/10214/ that:

• Native page size on Intel is 4 kB, on Apple Silicon it's 16 kB: therefore the PAGE_SIZE macro is no longer a constant. Use:
• PAGE_MAX_SIZE for a compile-time upper bound
• vm_page_size to read the actual value at runtime

[Eregon (Benoit Daloze)]

• Related to Feature #17752: Enable -Wundef for C extensions in repository added

[Eregon (Benoit Daloze)]

I wonder why Apple didn't simply define PAGE_SIZE conditionally based on the architecture.

[peterzhu2118 (Peter Zhu)]

• Assignee set to peterzhu2118 (Peter Zhu)

[peterzhu2118 (Peter Zhu)]

Thank you. I'm looking into this.

[peterzhu2118 (Peter Zhu)]

• Backport changed from 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN to 2.6: DONTNEED, 2.7: DONTNEED, 3.0: DONTNEED

[mame (Yusuke Endoh)]

• Status changed from Open to Closed

@nobu (Nobuyoshi Nakada) seemed to fix this issue by 3d5b6ddff8def49e59fb9a9ddd28a653498ae861 and 192150051144c0242ee44df26952dfe31b83cac2