Feature #15030: Have T_INTEGER constant for checking Integer types in C API

• Status: Rejected
• Assignee: -
• Target version: -

[v0dro (Sameer Deshmukh)]

After Integer unification in Ruby 2.4, I think it makes sense to introduce a T_INTEGER
type that helps in directly testing if a Ruby object is an Integer in C API.

For example, currently we need to write RB_TYPE_P(obj, T_FIXNUM) for this purpose.
However since ruby 2.4 onwards deprecates Fixnum and Bignum, I think it makes sense
to have a T_INTEGER type so that one can write RB_TYPE_P(obj, T_INTEGER) directly
to test for both 64-bit and > 64-bit integers.

[Hanmac (Hans Mackowiak)]

hm that is not that easy, while Fixnum and Bignum are deprecated on the ruby side,
on the C side they still exist

thats why a single T_INTEGER check might not work that way you want

[ko1 (Koichi Sasada)]

• Status changed from Open to Rejected

+1 for Hanmac.

C extension writers should check T_FIXNUM or T_BIGNUM explicitly.

[Eregon (Benoit Daloze)]

There are certainly cases where a C extension wants to check the argument is an Integer, and its range doesn't matter, isn't it?
Is there a macro to check for that easily?

[normalperson (Eric Wong)]

[e-mail] wrote:

There are certainly cases where a C extension wants to check the argument is an Integer, and its range doesn't matter, isn't it?
Is there a macro to check for that easily?

Not currently, just two calls to RB_TYPE_P but that's a trivial
static inline wrapper (no macros when a static inline will do).

For case, statements, perhaps something like:

#define case_T_INTEGER case T_FIXNUM: case T_BIGNUM

Along the same lines, I've used the following outside of Ruby
for dealing with EAGAIN/EWOULDBLOCK:

#if defined(EWOULDBLOCK) && (EWOULDBLOCK != EAGAIN)
#  define case_EAGAIN case EAGAIN: case EWOULDBLOCK
#else
#  define case_EAGAIN case EAGAIN
#endif
 
switch (errno) {
  case_EAGAIN: ...
  default: ...
}

[ko1 (Koichi Sasada)]

Eregon (Benoit Daloze) wrote:

There are certainly cases where a C extension wants to check the argument is an Integer, and its range doesn't matter, isn't it?

For example?

[nobu (Nobuyoshi Nakada)]

Use RB_INTEGER_TYPE_P().