Project

General

Profile

Actions

Bug #8621

closed

MinGW: Rational tests are causing error

Added by luislavena (Luis Lavena) over 10 years ago. Updated over 4 years ago.

Status:
Closed
Target version:
-
ruby -v:
trunk r41900
Backport:
[ruby-core:55923]

Description

Hello,

It seems that Rational related tests are causing failure in RubyInstaller CI:

http://ci.rubyinstaller.org/job/ruby-trunk-x86-test-all/1772/console

ComplexRational_Test#test_comp_srat = 0.00 s = .
ComplexRational_Test#test_rat_srat = make: *** [yes-test-all] Error 253

There is no backtrace or anything, but it has been failing over the last couple of builds repeatedly.

Updated by phasis68 (Heesob Park) over 10 years ago

This issue is raise from pow function failure of float on mingw-w64 x86.

C:\work>irb
irb(main):001:0> 1 ** 2
=> 1
irb(main):002:0> 1.0 ** 2.0

C:\work>

Exited without return value or exception.

I found that this failure is due to r41836.

The pow call is causing infinite self calling.
The macro "#define pow rb_w32_pow" in win32.h
and rb_32_pow function calls pow again in win32.c

I think the r41836 should be reverted.

Actions #2

Updated by nobu (Nobuyoshi Nakada) over 10 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r41923.
Luis, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


win32.c: fix infinite recursion

Updated by luislavena (Luis Lavena) over 10 years ago

  • Status changed from Closed to Assigned
  • Assignee changed from tadf (tadayoshi funaba) to nobu (Nobuyoshi Nakada)
  • % Done changed from 100 to 50

Thank you nobu, but seems we are back to the floating error again:

http://ci.rubyinstaller.org/job/ruby-trunk-x86-test-all/1784/console

   1) Failure:
 TestSprintf#test_float [C:/Users/Worker/Jenkins/workspace/ruby-trunk-x86-build/test/ruby/test_sprintf.rb:193]:
 [ruby-dev:42551].
 <"0x1p+2"> expected but was
 <"0x1p+1">.

Updated by hsbt (Hiroshi SHIBATA) about 10 years ago

  • Target version changed from 2.1.0 to 2.2.0
Actions #5

Updated by naruse (Yui NARUSE) about 6 years ago

  • Target version deleted (2.2.0)

Updated by jeremyevans0 (Jeremy Evans) over 4 years ago

  • Status changed from Assigned to Closed
  • Backport deleted (1.9.3: UNKNOWN, 2.0.0: UNKNOWN)

The floating error was fixed (test disabled and considered out of spec) by b2a128fa7cabcce182e7360db70b3e50bb39242d.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0