Project

General

Profile

Actions

Backport #776

closed

File#flush doesn't flush in windows

Added by rogerdpack (Roger Pack) over 15 years ago. Updated almost 13 years ago.


Description

=begin
In windows, File#flush flushes ruby's internal buffers, however, the result is different from Linux.
I'd recommend adding an arbitrary fsync if you're in windows to ensure the buffers are actually flushed, to avoid unexpected cross platform bugs [such as one that attachment_fu has].
[ruby-core:19940]
This in 1.9/1.8.x
Thanks!
-=Roger
=end

Actions #1

Updated by matz (Yukihiro Matsumoto) over 15 years ago

  • Assignee set to usa (Usaku NAKAMURA)

=begin

=end

Actions #2

Updated by usa (Usaku NAKAMURA) over 15 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

=begin
Applied in changeset r20982.
=end

Actions #3

Updated by rogerdpack (Roger Pack) over 15 years ago

=begin
Thanks for doing that. Would it be possible to backport these to 1.8 branch, too?

=end

Actions #4

Updated by rogerdpack (Roger Pack) about 15 years ago

=begin
Wonder if it's related to recent zlib difficulties:
http://www.misuse.org/science/2007/09/07/ruby-zlib-buffer-error-on-windows/`

=end

Actions #5

Updated by shyouhei (Shyouhei Urabe) about 15 years ago

  • Status changed from Closed to Open
  • % Done changed from 100 to 0

=begin
Moved to backport/1.8
=end

Actions #6

Updated by usa (Usaku NAKAMURA) over 14 years ago

  • Status changed from Open to Assigned

=begin

=end

Actions #7

Updated by usa (Usaku NAKAMURA) over 14 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

=begin
Applied in changeset r24223.
=end

Actions #8

Updated by rogerdpack (Roger Pack) over 14 years ago

=begin
thanks for doing that.
=r
=end

Actions #9

Updated by shyouhei (Shyouhei Urabe) over 14 years ago

  • Status changed from Closed to Assigned
  • Assignee changed from usa (Usaku NAKAMURA) to shyouhei (Shyouhei Urabe)

=begin

=end

Actions #10

Updated by shyouhei (Shyouhei Urabe) over 14 years ago

  • Status changed from Assigned to Closed

=begin
Applied in changeset r24406.
=end

Actions #11

Updated by shyouhei (Shyouhei Urabe) over 14 years ago

  • Status changed from Closed to Assigned
  • Assignee changed from shyouhei (Shyouhei Urabe) to wyhaines (Kirk Haines)

=begin

=end

Actions #12

Updated by wyhaines (Kirk Haines) almost 14 years ago

  • Status changed from Assigned to Closed

=begin
This issue was solved with changeset r28003.
Roger, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

=end

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0Like0Like0Like0Like0Like0Like0