Actions
Misc #17569
closed
`uri` lib maintainership
Misc #17569:
`uri` lib maintainership
Status:
Closed
Assignee:
Description
I’d like to merge https://github.com/ruby/uri/pull/15 but it is an API change. I would release v1.0.0. @akr (Akira Tanaka) is the official maintainer of uri… Is he still interested in this role? Otherwise we could put “Ruby core team” in the listing…
Updated by nobu (Nobuyoshi Nakada) over 4 years ago
That strategy doesn’t feel nice to me.
Updated by marcandre (Marc-Andre Lafortune) over 4 years ago
@nobu (Nobuyoshi Nakada) which strategy is that? Do you mean the register_scheme API?
Updated by nobu (Nobuyoshi Nakada) over 4 years ago
Yes, replacing the constant.
Updated by marcandre (Marc-Andre Lafortune) over 4 years ago
I don't know of another approach that is as easy and performant than to store a mostly fixed config like this. What did you have in mind?
Updated by Eregon (Benoit Daloze) over 4 years ago
Would using an @ivar on the URI module work?
https://github.com/ruby/uri/pull/15#discussion_r563082346
Updated by hsbt (Hiroshi SHIBATA) over 1 year ago
- Status changed from Open to Assigned
Updated by hsbt (Hiroshi SHIBATA) over 1 year ago
- Status changed from Assigned to Closed
- Assignee changed from akr (Akira Tanaka) to hsbt (Hiroshi SHIBATA)
We have been merged the followings instead of https://github.com/ruby/uri/pull/15
- https://github.com/ruby/uri/pull/22
- https://github.com/ruby/uri/pull/26
- https://github.com/ruby/uri/pull/27
I'll close this.
Actions