Bug #16658
closed`method__cache__clear` DTrace hook was dropped without replacement
Description
Updated by vo.x (Vit Ondruch) over 4 years ago
- Related to Feature #16614: New method cache mechanism for Guild added
Updated by vo.x (Vit Ondruch) over 4 years ago
- Assignee set to ko1 (Koichi Sasada)
@Koichi could you please take a look, since your commit removed the hook. Thx
Updated by ko1 (Koichi Sasada) over 4 years ago
Sorry. what method__cache__clear
did?
When this hook was invoked?
Updated by vo.x (Vit Ondruch) over 4 years ago
ko1 (Koichi Sasada) wrote in #note-3:
Sorry. what
method__cache__clear
did?
I don't really know. @tenderlovemaking (Aaron Patterson) is the author AFAIK. But this is the comment from probes.d:
ruby:::method-cache-clear(class, filename, lineno);
This probe is fired when the method cache is cleared.
* `class` the name of the class or "global" (a string)
* `filename` the file name where the cache is _being cleared_ (a string)
* `lineno` the line number where the cache is _being cleared_ (an int)
When this hook was invoked?
https://github.com/ruby/ruby/pull/2888/files#diff-6cea7716df08f2b7fdc5fb30c7963884L98
Updated by vo.x (Vit Ondruch) over 4 years ago
When this hook was invoked?
https://github.com/ruby/ruby/pull/2888/files#diff-6cea7716df08f2b7fdc5fb30c7963884L98
Hm, this does not appear to really work, since the vm_method.c is collapsed. Anyway, this used to be the invocation place:
https://github.com/ruby/ruby/blob/f2286925f08406bc857f7b03ad6779a5d61443ae/vm_method.c#L98
Updated by ko1 (Koichi Sasada) over 4 years ago
Thanks, I think there is no chance to invoke this hook on current master.
Updated by vo.x (Vit Ondruch) over 4 years ago
ko1 (Koichi Sasada) wrote in #note-6:
Thanks, I think there is no chance to invoke this hook on current master.
Could you please adjust the probes.d then? Thx.
Updated by vo.x (Vit Ondruch) almost 4 years ago
Could this be fixed prior Ruby 3.0 release please?
Updated by ko1 (Koichi Sasada) almost 4 years ago
- Status changed from Open to Closed
Applied in changeset git|b32ed8aa41795e3b153b423ae14d2699060d73db.
remove method__cache__clear
DTrace probe method__cache__clear is no longer used.
[Bug #16658]
Updated by ko1 (Koichi Sasada) almost 4 years ago
Thank you for the reminder!