https://redmine.ruby-lang.org/https://redmine.ruby-lang.org/favicon.ico?17113305112020-02-27T09:49:04ZRuby Issue Tracking SystemRuby master - Bug #16658: `method__cache__clear` DTrace hook was dropped without replacementhttps://redmine.ruby-lang.org/issues/16658?journal_id=844082020-02-27T09:49:04Zvo.x (Vit Ondruch)v.ondruch@tiscali.cz
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/16614">Feature #16614</a>: New method cache mechanism for Guild</i> added</li></ul> Ruby master - Bug #16658: `method__cache__clear` DTrace hook was dropped without replacementhttps://redmine.ruby-lang.org/issues/16658?journal_id=849652020-04-08T16:49:01Zvo.x (Vit Ondruch)v.ondruch@tiscali.cz
<ul><li><strong>Assignee</strong> set to <i>ko1 (Koichi Sasada)</i></li></ul><p>@Koichi could you please take a look, since your commit removed the hook. Thx</p> Ruby master - Bug #16658: `method__cache__clear` DTrace hook was dropped without replacementhttps://redmine.ruby-lang.org/issues/16658?journal_id=854082020-05-07T07:14:27Zko1 (Koichi Sasada)
<ul></ul><p>Sorry. what <code>method__cache__clear</code> did?<br>
When this hook was invoked?</p> Ruby master - Bug #16658: `method__cache__clear` DTrace hook was dropped without replacementhttps://redmine.ruby-lang.org/issues/16658?journal_id=854352020-05-07T18:51:58Zvo.x (Vit Ondruch)v.ondruch@tiscali.cz
<ul></ul><p>ko1 (Koichi Sasada) wrote in <a href="#note-3">#note-3</a>:</p>
<blockquote>
<p>Sorry. what <code>method__cache__clear</code> did?</p>
</blockquote>
<p>I don't really know. <a class="user active user-mention" href="https://redmine.ruby-lang.org/users/73">@tenderlovemaking (Aaron Patterson)</a> is the author AFAIK. But this is the comment from probes.d:</p>
<pre><code> ruby:::method-cache-clear(class, filename, lineno);
This probe is fired when the method cache is cleared.
* `class` the name of the class or "global" (a string)
* `filename` the file name where the cache is _being cleared_ (a string)
* `lineno` the line number where the cache is _being cleared_ (an int)
</code></pre>
<blockquote>
<p>When this hook was invoked?</p>
</blockquote>
<p><a href="https://github.com/ruby/ruby/pull/2888/files#diff-6cea7716df08f2b7fdc5fb30c7963884L98" class="external">https://github.com/ruby/ruby/pull/2888/files#diff-6cea7716df08f2b7fdc5fb30c7963884L98</a></p> Ruby master - Bug #16658: `method__cache__clear` DTrace hook was dropped without replacementhttps://redmine.ruby-lang.org/issues/16658?journal_id=854362020-05-07T18:56:29Zvo.x (Vit Ondruch)v.ondruch@tiscali.cz
<ul></ul><blockquote>
<blockquote>
<p>When this hook was invoked?</p>
</blockquote>
<p><a href="https://github.com/ruby/ruby/pull/2888/files#diff-6cea7716df08f2b7fdc5fb30c7963884L98" class="external">https://github.com/ruby/ruby/pull/2888/files#diff-6cea7716df08f2b7fdc5fb30c7963884L98</a></p>
</blockquote>
<p>Hm, this does not appear to really work, since the vm_method.c is collapsed. Anyway, this used to be the invocation place:</p>
<p><a href="https://github.com/ruby/ruby/blob/f2286925f08406bc857f7b03ad6779a5d61443ae/vm_method.c#L98" class="external">https://github.com/ruby/ruby/blob/f2286925f08406bc857f7b03ad6779a5d61443ae/vm_method.c#L98</a></p> Ruby master - Bug #16658: `method__cache__clear` DTrace hook was dropped without replacementhttps://redmine.ruby-lang.org/issues/16658?journal_id=854492020-05-07T21:46:09Zko1 (Koichi Sasada)
<ul></ul><p>Thanks, I think there is no chance to invoke this hook on current master.</p> Ruby master - Bug #16658: `method__cache__clear` DTrace hook was dropped without replacementhttps://redmine.ruby-lang.org/issues/16658?journal_id=854502020-05-07T21:50:36Zvo.x (Vit Ondruch)v.ondruch@tiscali.cz
<ul></ul><p>ko1 (Koichi Sasada) wrote in <a href="#note-6">#note-6</a>:</p>
<blockquote>
<p>Thanks, I think there is no chance to invoke this hook on current master.</p>
</blockquote>
<p>Could you please adjust the probes.d then? Thx.</p> Ruby master - Bug #16658: `method__cache__clear` DTrace hook was dropped without replacementhttps://redmine.ruby-lang.org/issues/16658?journal_id=894182020-12-22T11:49:21Zvo.x (Vit Ondruch)v.ondruch@tiscali.cz
<ul></ul><p>Could this be fixed prior Ruby 3.0 release please?</p> Ruby master - Bug #16658: `method__cache__clear` DTrace hook was dropped without replacementhttps://redmine.ruby-lang.org/issues/16658?journal_id=894502020-12-23T17:00:09Zko1 (Koichi Sasada)
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li></ul><p>Applied in changeset <a class="changeset" title="remove method__cache__clear DTrace probe method__cache__clear is no longer used. [Bug #16658]" href="https://redmine.ruby-lang.org/projects/ruby-master/repository/git/revisions/b32ed8aa41795e3b153b423ae14d2699060d73db">git|b32ed8aa41795e3b153b423ae14d2699060d73db</a>.</p>
<hr>
<p>remove method__cache__clear</p>
<p>DTrace probe method__cache__clear is no longer used.<br>
[Bug <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: `method__cache__clear` DTrace hook was dropped without replacement (Closed)" href="https://redmine.ruby-lang.org/issues/16658">#16658</a>]</p> Ruby master - Bug #16658: `method__cache__clear` DTrace hook was dropped without replacementhttps://redmine.ruby-lang.org/issues/16658?journal_id=894512020-12-23T17:00:31Zko1 (Koichi Sasada)
<ul></ul><p>Thank you for the reminder!</p>