Project

General

Profile

Actions

Feature #15306

closed

Generate prelude.c using miniruby

Added by vo.x (Vit Ondruch) over 5 years ago. Updated over 4 years ago.

Status:
Closed
Assignee:
-
Target version:
-
[ruby-core:89806]

Description

I don't see any reason why prelude.c should be included in source tarball and why it should not be generated by miniruby. Please see the attached patch.

Please note this is a clone of #10554, which was closed just because it was old, not because it was resolved.


Files

Updated by normalperson (Eric Wong) over 5 years ago

wrote:

https://bugs.ruby-lang.org/issues/15306

I don't see any reason why prelude.c should be included in
source tarball

I agree with this part, BASERUBY is already a build requirement
of Ruby and making a smaller source tarball is beneficial to users
and hosters.

and why it should not be generated by miniruby.

I disagree with this. I would like to implement more of Ruby
using Ruby, so miniruby may depend on prelude one day.

Updated by shyouhei (Shyouhei Urabe) over 5 years ago

On Thu, Nov 15, 2018 at 7:10 PM Eric Wong wrote:

I don't see any reason why prelude.c should be included in
source tarball

I agree with this part, BASERUBY is already a build requirement
of Ruby and making a smaller source tarball is beneficial to users
and hosters.

Well I can live when ruby depends itself, but then, bootstrapping
can be an issue for people. And I wonder if Vit is requesting that.

Updated by vo.x (Vit Ondruch) over 5 years ago

In this specific case, I am concerned about the possibility of patching Ruby, specifically #8566.

It is, unfortunately, a bit more complex with the bootstrapping. Ideally, the content of tarball should be the same as the content of the upstream repository, because, in Fedora, there are guidelines such as 1. OTOH, using Ruby to bootstrap Ruby is problematic, because of the necessity of bootstrapping new distributions (RHEL8 Beta was released yesterday 2, yay!) and new platforms.

Generally, I would be glad if as much code as possible is generated during the build and the amount of pre-generated code shipped in the released tarball is minimal, while I'd like to avoid dependency on Ruby. Miniruby is helping with both cases, so I appreciate the existence of Miniruby.

Actions #4

Updated by jeremyevans0 (Jeremy Evans) over 4 years ago

  • Tracker changed from Bug to Feature
  • ruby -v deleted (ruby 2.6.0preview3 (2018-11-06 trunk 65578) [x86_64-linux])
  • Backport deleted (2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN)

Updated by vo.x (Vit Ondruch) over 4 years ago

prelude.c is not anymore 1, so I'm closing this specific ticket.

However, I'll be happy if the discussion is remembered for future.

Actions #6

Updated by vo.x (Vit Ondruch) over 4 years ago

  • Status changed from Open to Closed
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0