Project

General

Profile

Feature #15306

Generate prelude.c using miniruby

Added by vo.x (Vit Ondruch) about 1 year ago. Updated 4 months ago.

Status:
Open
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:89806]

Description

I don't see any reason why prelude.c should be included in source tarball and why it should not be generated by miniruby. Please see the attached patch.

Please note this is a clone of #10554, which was closed just because it was old, not because it was resolved.


Files

History

Updated by normalperson (Eric Wong) about 1 year ago

v.ondruch@tiscali.cz wrote:

https://bugs.ruby-lang.org/issues/15306

I don't see any reason why prelude.c should be included in
source tarball

I agree with this part, BASERUBY is already a build requirement
of Ruby and making a smaller source tarball is beneficial to users
and hosters.

and why it should not be generated by miniruby.

I disagree with this. I would like to implement more of Ruby
using Ruby, so miniruby may depend on prelude one day.

Updated by shyouhei (Shyouhei Urabe) about 1 year ago

On Thu, Nov 15, 2018 at 7:10 PM Eric Wong normalperson@yhbt.net wrote:

I don't see any reason why prelude.c should be included in
source tarball

I agree with this part, BASERUBY is already a build requirement
of Ruby and making a smaller source tarball is beneficial to users
and hosters.

Well I can live when ruby depends itself, but then, bootstrapping
can be an issue for people. And I wonder if Vit is requesting that.

Updated by vo.x (Vit Ondruch) about 1 year ago

In this specific case, I am concerned about the possibility of patching Ruby, specifically #8566.

It is, unfortunately, a bit more complex with the bootstrapping. Ideally, the content of tarball should be the same as the content of the upstream repository, because, in Fedora, there are guidelines such as 1. OTOH, using Ruby to bootstrap Ruby is problematic, because of the necessity of bootstrapping new distributions (RHEL8 Beta was released yesterday 2, yay!) and new platforms.

Generally, I would be glad if as much code as possible is generated during the build and the amount of pre-generated code shipped in the released tarball is minimal, while I'd like to avoid dependency on Ruby. Miniruby is helping with both cases, so I appreciate the existence of Miniruby.

#4

Updated by jeremyevans0 (Jeremy Evans) 4 months ago

  • Backport deleted (2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN)
  • ruby -v deleted (ruby 2.6.0preview3 (2018-11-06 trunk 65578) [x86_64-linux])
  • Tracker changed from Bug to Feature

Also available in: Atom PDF