Project

General

Profile

Feature #14153

[PATCH] resurrection of # -*- warn_past_scope: true -*-

Added by shyouhei (Shyouhei Urabe) about 3 years ago. Updated about 3 years ago.

Status:
Open
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:84080]

Description

From 2addeedcf8838dc15d127fffd888962b34879439 Mon Sep 17 00:00:00 2001
From: "Urabe, Shyouhei" <shyouhei@ruby-lang.org>
Date: Mon, 4 Dec 2017 19:28:55 +0900
Subject: [PATCH] resurrection of # -*- warn_past_scope: true -*-

I understand this feature was killed due to [Bug #10661].

However sometimes i _do_ want to check variable name collisions.

Please consider this feature again, with default off; no warning shall
be emitted unless theere are the dedicated magic comment in the source
code.

Signed-off-by: Urabe, Shyouhei <shyouhei@ruby-lang.org>
---
 parse.y | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/parse.y b/parse.y
index 03b9ed992e..a4a31af5e0 100644
--- a/parse.y
+++ b/parse.y
@@ -37,7 +37,7 @@
 #include "probes.h"

 #ifndef WARN_PAST_SCOPE
-# define WARN_PAST_SCOPE 0
+# define WARN_PAST_SCOPE 1
 #endif

 #define TAB_WIDTH 8
-- 
2.15.1

Related issues

Related to Ruby master - Bug #10661: The "possible reference to past scope" warning is quite frustrating and is forcing me to change my variable names from what I wantClosed12/27/2014Actions

Also available in: Atom PDF