Project

General

Profile

Actions

Feature #13653

closed

Bundled zlib helper

Added by hsbt (Hiroshi SHIBATA) almost 7 years ago. Updated about 2 years ago.

Status:
Closed
Target version:
-
[ruby-core:81660]

Description

I created experimentally implementation for zlib-binding helper of bundled build.

I also maintain ruby-build that is multi-platform build wrapper for ruby. I often got build failure
report caused to missing zlib headers. examples are here.

I hope to resolve this situation for ruby users.

my patch make to build zlib-binding with bundled zlib sources. It only enabled when It was given
--enable-bundled-zlib option with configure phase.

Updated by nobu (Nobuyoshi Nakada) almost 7 years ago

I think --enable-bundled-zlib should suppress looking for external libraries and headers, as well as fiddle and psych.

Actions #2

Updated by hsbt (Hiroshi SHIBATA) over 6 years ago

  • Status changed from Open to Assigned

Updated by shyouhei (Shyouhei Urabe) over 6 years ago

We took a look at this issue at yesterday's developer meeting.

It surprised me that currently, zlib and several other header files are mandatory for building ruby from the source. It might be trivial for developers like us, but not for everyone who try compiling ruby.

The solutions to cover this glitch might include:

  • Ship zlib along with ruby. This menu has additional choice whether the bundled zlib shall be statically linked or not.
  • Fetch and compile zlib before building ruby, by the ruby-build script. This one needs to pass the result of zlib detection between ruby and ruby-build.

Either way ext/zlib has to be aware of the situation. The OP's pull request is for that purpose.

Updated by hsbt (Hiroshi SHIBATA) over 6 years ago

  • Target version set to 2.6

To. shyouhei

Thanks for your explanation.

I updated my pull request. It only download and add zlib source files to ruby package(like tar ball)

https://patch-diff.githubusercontent.com/raw/ruby/ruby/pull/1638.diff

I try to this helper to ruby-build or add this feature to Ruby 2.6.

Actions #5

Updated by naruse (Yui NARUSE) about 6 years ago

  • Target version deleted (2.6)

Updated by hsbt (Hiroshi SHIBATA) about 2 years ago

  • Status changed from Assigned to Closed

After 4 years, We should remove the bundled source code like zlib, libyaml, libffi.

for mswin users: use vcpkg, other platforms: use the official package manager like apt, dnf.

Updated by Eregon (Benoit Daloze) about 2 years ago

And for macOS: try to not mess up your system by installing random stuff in /usr/local, that's the source of many issues reported to ruby-build.
Using Homebrew is fine (or MacPorts), but manually installing stuff in /usr/local is asking for trouble.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0Like0