Project

General

Profile

Actions

Feature #12813

closed

Calling chunk_while, slice_after, slice_before, slice_when with no block

Added by marcandre (Marc-Andre Lafortune) about 8 years ago. Updated almost 2 years ago.

Status:
Closed
Target version:
-
[ruby-core:77499]

Description

Currently, chunk_while, slice_after, slice_before, slice_when all require a block.

If one needs the index within the block, there is no good way to do this; enum.each_with_index.chunk_while would have indices in the results, so enum.enum_for(:chunk_while).with_index is the best solution.

I feel that we should return enum_for(:chunk_while). This is strictly more useful than raising as we currently do.

Updated by shyouhei (Shyouhei Urabe) almost 8 years ago

  • Status changed from Open to Assigned

We briefly looked at this issue in todays developer meeting but had no time to fully agree that the proposed extension is safe. We just did not reach a conclusion.

Updated by marcandre (Marc-Andre Lafortune) almost 8 years ago

It would help if you explained what is meant by "safe".

There is currently no valid usage of chunk_while, slice_after, slice_before or slice_when without a block and an argument, as they all raise an exception. So "extending" them by returning an enumerator instead can't reasonably produce a problem. So what else could be meant by "safe"?

Updated by matz (Yukihiro Matsumoto) almost 8 years ago

After consideration, I accept this proposal.

Matz.

Updated by sawa (Tsuyoshi Sawada) almost 2 years ago

I think this has already been implemented by now. It should be closed.

Actions #5

Updated by hsbt (Hiroshi SHIBATA) almost 2 years ago

  • Status changed from Assigned to Closed
Actions

Also available in: Atom PDF

Like1
Like0Like0Like0Like0Like0