Project

General

Profile

Actions

Bug #11230

closed

Should rb_struct_s_members() be public API?

Added by Eregon (Benoit Daloze) almost 9 years ago. Updated about 1 year ago.

Status:
Rejected
Assignee:
-
Target version:
-
ruby -v:
ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-linux]
[ruby-core:69481]
Tags:

Description

rb_struct_s_members() is declared in include/ruby/intern.h.

However it seems this is a fairly internal API as it returns an hidden Array.

For instance, there was a try to specify the behavior in
https://github.com/rubinius/rubinius/commit/2642a30c57973987d2a7b7e85b3ce1e78100a31b
but that produces only erratic behavior on MRI because that usage is not intended.

A valid usage might be:

static VALUE get_struct_member(VALUE self, VALUE obj, VALUE i) {
    return RARRAY_AREF(rb_struct_s_members(obj), NUM2INT(i));
}

p get_struct_member(Struct.new(:a, :bb), 1)

But do we need such access and is it worth exposing a potentially dangerous function like this?

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0