Project

General

Profile

Actions

Misc #10339

closed

normalize reference to Timeout::Error

Added by jjb (John Bachir) about 10 years ago. Updated about 6 years ago.

Status:
Closed
Assignee:
-
[ruby-core:65481]

Description

normalize references to Timeout::Error

TimeoutError is a legacy constant, Timeout::Error is the canonical constant.
This patch normalizes all code and comments to reference Timeout::Error.


Files

timeout-error-name-normalization.patch (6.06 KB) timeout-error-name-normalization.patch jjb (John Bachir), 10/07/2014 06:23 PM

Related issues 1 (0 open1 closed)

Related to Ruby master - Feature #10342: Module#deprecate_constantClosedmatz (Yukihiro Matsumoto)Actions

Updated by normalperson (Eric Wong) about 10 years ago

The doc/ChangeLog-1.9.3 modification is incorrect. I will remove it and
commit the rest:

normalize reference to Timeout::Error

From: John Bachir

  • bootstraptest/test_io.rb (assert_finish):
    normalize rescue for Timeout::Error
  • lib/net/ftp.rb (Net#read_timeout): ditto for doc
  • lib/resolv.rb (Resolv::ResolvTimeout): ditto for subclass
  • lib/webrick/httprequest.rb (_read_data): ditto for rescue
  • sample/timeout.rb (p timeout): ditto for call
  • test/drb/drbtest.rb (test_06_timeout): ditto
  • test/ruby/test_readpartial.rb (test_open_pipe): ditto
  • test/thread/test_queue.rb (test_queue_thread_raise): ditto
  • thread.c (rb_thread_s_handle_interrupt): ditto for doc
    [ruby-core:65481] [misc #10339]

TimeoutError is a legacy constant, Timeout::Error is the canonical constant.
This patch normalizes all code and comments to reference Timeout::Error.

Updated by nobu (Nobuyoshi Nakada) about 10 years ago

Updated by jjb (John Bachir) about 10 years ago

The doc/ChangeLog-1.9.3 modification is incorrect.

Whoops, sloppy of me!

I will remove it and commit the rest

Thanks!

Actions #4

Updated by hsbt (Hiroshi SHIBATA) about 6 years ago

  • Status changed from Open to Closed
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0