Project

General

Profile

Actions

Bug #9186

closed

json/pure.rb missing on trunk

Added by Anonymous over 10 years ago. Updated about 10 years ago.

Status:
Rejected
Target version:
ruby -v:
ruby 2.1.0dev (2013-11-30 trunk 43927) [x86_64-darwin13.0]
[ruby-core:58724]

Description

Line 60 of ext/json/lib/json.rb requires json/pure if json/ext cannot be required.

This file is missing on trunk, meaning the JSON library is broken unless the C extension is present.

Updated by hsbt (Hiroshi SHIBATA) over 10 years ago

  • Assignee set to naruse (Yui NARUSE)
  • Target version set to 2.1.0

Updated by vo.x (Vit Ondruch) over 10 years ago

I'm just wondering, what should be the circumstances that C extension is missing?

Updated by Anonymous over 10 years ago

@vo.x (Vit Ondruch): I noticed this because it was breaking on Rubinius - there's also probably some situations where C extensions can't be loaded in CRuby.

Updated by kosaki (Motohiro KOSAKI) over 10 years ago

there's also probably some situations where C extensions can't be loaded in CRuby.

Hmm.. When? It shouldn't happen on CRuby.

Updated by Anonymous over 10 years ago

Hmm.. When? It shouldn't happen on CRuby.

It isn't a common use case, but I have experienced some issues with C extensions when cross-compiling CRuby.

Updated by kosaki (Motohiro KOSAKI) over 10 years ago

2013/12/1 charliesome (Charlie Somerville) :

Issue #9186 has been updated by charliesome (Charlie Somerville).

Hmm.. When? It shouldn't happen on CRuby.

It isn't a common use case, but I have experienced some issues with C extensions when cross-compiling CRuby.

Can you please elaborate more? Do you mean JSON is now cross-compile
unsafe? It seems horrible.

Updated by Anonymous over 10 years ago

Can you please elaborate more? Do you mean JSON is now cross-compile unsafe? It seems horrible.

This was a long time ago, and I can't recall specific details. I was just using this as an example of when C extensions may not work properly and this bug could be triggered in CRuby.

Updated by naruse (Yui NARUSE) about 10 years ago

  • Status changed from Open to Rejected

I intentionally removed pure.rb on ruby's repo because CRuby always have C exts.

If C exts is not properly build, the binary shouldn't work.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0Like0Like0