Bug #8769: [PATCH] process.c (rb_fork_internal): remove cloexec setting

• Status: Closed
• Assignee: nobu (Nobuyoshi Nakada)
• Target version: 2.1.0
• ruby -v: ruby 2.1.0dev (2013-08-10 trunk 42491) [x86_64-linux]
• Backport: 1.9.3: DONTNEED, 2.0.0: DONE

[normalperson (Eric Wong)]

The close-on-exec flag is already set via:
pipe_nocrash -> rb_pipe -> rb_cloexec_pipe
Calling fcntl here is redundant.

[nobu (Nobuyoshi Nakada)]

Seems reasonable.

[naruse (Yui NARUSE)]

• Status changed from Open to Assigned
• Assignee set to nobu (Nobuyoshi Nakada)

nobu, could you commit this?

[nobu (Nobuyoshi Nakada)]

Eric can't?

[normalperson (Eric Wong)]

"nobu (Nobuyoshi Nakada)" [e-mail] wrote:

Eric can't?

I never accepted commit bit to any project in years. I'm not
trustworthy/sane enough nor do I want to feel obligated to Ruby.

It should be easier to accept patches from drive-by contributors such as
myself, though. IMHO, maintaining ChangeLog in repository makes
applying/merging patches harder (vs using commit message + generated
changelog in dist tarball).

[nobu (Nobuyoshi Nakada)]

• Status changed from Assigned to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r43008.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

process.c: remove cloexec setting

• process.c (rb_fork_internal): remove cloexec setting on pipes
  created by rb_cloexec_pipe. patch by normalperson (Eric Wong) at
  [ruby-core:56523]. [Bug #8769]

[nobu (Nobuyoshi Nakada)]

• Backport changed from 1.9.3: UNKNOWN, 2.0.0: UNKNOWN to 1.9.3: DONTNEED, 2.0.0: REQUIRED

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 1.9.3: DONTNEED, 2.0.0: REQUIRED to 1.9.3: DONTNEED, 2.0.0: DONE

backported to ruby_2_0_0 at r43227.