Project

General

Profile

Actions
Copy link

Bug #7744

closed

Fix signed integer overflows Github #242

Added by zzak (zzak _) almost 12 years ago. Updated almost 11 years ago.

Status:
Closed
Assignee:
nobu (Nobuyoshi Nakada)
Target version:
2.1.0
ruby -v:
2.0.0
Backport:
[ruby-core:51711]

Description

=begin
From ((<github issue 242|URL:https://github.com/ruby/ruby/pull/242>)):

((Signed integer overflow is undefined behavior in C. Many compilers assume no signed integer overflows and even optimize away overflow checks. The -fno-strict-overflow flag works around this issue in gcc, but doesn't fix the fundamentally broken code.))

((This patchset fixes signed integer overflows in time.c, ossl.c, and bigdecimal.c.))

I've attached the associated patch.
=end

Files

242.patch (4.09 KB) 242.patch zzak (zzak _), 01/28/2013 02:14 AM
Actions
Copy link
 #1 [ruby-core:52411]

Updated by ko1 (Koichi Sasada) over 11 years ago

  • Assignee set to nobu (Nobuyoshi Nakada)
  • Target version changed from 2.6 to 2.1.0
Actions
Copy link
 #2

Updated by nobu (Nobuyoshi Nakada) almost 11 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r44395.
Zachary, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

ossl.c: integer overflow

Actions
Copy link

Also available in: Atom PDF

Like0
Like0Like0