Project

General

Profile

Actions

Bug #7398

closed

Modify TestSSL#test_read_and_write to handle partial sysreads

Added by zzak (zzak _) over 11 years ago. Updated almost 10 years ago.

Status:
Closed
Target version:
ruby -v:
2.0.0
Backport:
[ruby-core:49563]

Description

=begin
from github: https://github.com/ruby/ruby/pull/204

((*SSLSocket#sysread can return fewer bytes than you request. This test does client reads and writes and server reads and writes concurrently, which means on a parallel-threaded implementation like JRuby there's a chance the client side will see partial data come from sysread.

My change here ensures that the sysread has read everything written before doing comparisons, allowing for partial sysread results.*))
=end


Files

openssl_test_read_and_write.patch (2.29 KB) openssl_test_read_and_write.patch zzak (zzak _), 11/19/2012 01:03 PM

Updated by zzak (zzak _) over 11 years ago

=begin
Description update:

((SSLSocket#sysread can return fewer bytes than you request. This test does client reads and writes and server reads and writes concurrently, which means on a parallel-threaded implementation like JRuby there's a chance the client side will see partial data come from sysread.))

((My change here ensures that the sysread has read everything written before doing comparisons, allowing for partial sysread results.))
=end

Updated by usa (Usaku NAKAMURA) over 11 years ago

  • Status changed from Open to Assigned

Updated by mame (Yusuke Endoh) about 11 years ago

  • Target version changed from 2.0.0 to 2.6

Just an issue of test.

--
Yusuke Endoh

Updated by hsbt (Hiroshi SHIBATA) almost 10 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

Applied in changeset r46164.


  • test/openssl/test_pair.rb: Modify TestSSL#test_read_and_write
    to handle partial sysreads. [Bug #7398][ruby-core:49563]
  • test/openssl/test_ssl.rb: ditto.
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0