Bug #6750: Comment above rb_iseq_struct.local_size gives out of date description

• Status: Closed
• Assignee: ko1 (Koichi Sasada)
• Target version: -
• ruby -v: 2.0.0dev

[davidbalbert (David Albert)]

The description of rb_iseq_struct.local_size says that it is sizeof(local vars) + 1 for class and method frames, but just sizeof(local vars) for block frames. I think this is no longer the case. local_size is always sizeof(local vars) + 1.

Here's the relevant code from when the comment was written (2007): https://github.com/ruby/ruby/blob/71986ef6bc232455deca67017873fff0c3cbd860/compile.c#L5004-5010
And here's the code today: https://github.com/ruby/ruby/blob/trunk/compile.c#L5571

I've attached a patch that fixes the comment.

[mame (Yusuke Endoh)]

• Status changed from Open to Assigned
• Assignee set to ko1 (Koichi Sasada)

Thank you. Ko1, do you apply his patch? It is clearly benign.

--
Yusuke Endoh [e-mail]

[ko1 (Koichi Sasada)]

• Status changed from Assigned to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r38936.
David, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

• vm_core.h: modify a comment about rb_iseq_t::local_size.
  A patch by davidbalbert (David Albert) [Bug #6750]

[ko1 (Koichi Sasada)]

I'm sorry I missed this issue (because no "target version". sorry again).
I applied it.

Thanks!