Bug #6454: Anonymous classes should delete tmp_classpath on dup

• Status: Closed
• Assignee: drbrain (Eric Hodel)
• Target version: -
• ruby -v: ruby 2.0.0dev (2012-05-19 trunk 35705) [x86_64-darwin11.4.0]

[tenderlovemaking (Aaron Patterson)]

When an anonymous class is duped, it should delete tmp_classpath from the iv table so that subsequent calls to inspect on the duped class will have different results.

I've attached a test case to demonstrate the problem.

[drbrain (Eric Hodel)]

• File rb_mod_init_copy.bug6454.patch rb_mod_init_copy.bug6454.patch added

This patch fixes the name of dup'd anonymous classes (and modules).

[mame (Yusuke Endoh)]

• Status changed from Open to Assigned
• Assignee set to matz (Yukihiro Matsumoto)

Aaron, you'd better think we are really lazy :-)
It would be good not only to attach a demonstration patch but also
to write the demonstration in the mail.

x = Class.new
y = x.dup
p x #=> #Class:0x9a96ce0
p y #=> #Class:0x9a96cb8 # they are different as expected,

x = Class.new
x.inspect # but if #inspect is called before #dup,
y = x.dup
p x #=> #Class:0x9113c7c
p y #=> #Class:0x9113c7c # they become same.

I give +1 to drbrain's patch.

--
Yusuke Endoh [e-mail]

• File noname noname added

On Mon, May 21, 2012 at 08:20:48PM +0900, mame (Yusuke Endoh) wrote:

Issue #6454 has been updated by mame (Yusuke Endoh).

Status changed from Open to Assigned
Assignee set to matz (Yukihiro Matsumoto)

Aaron, you'd better think we are really lazy :-)

Haha! Sorry about that. I am also really lazy!

It would be good not only to attach a demonstration patch but also
to write the demonstration in the mail.

I will try to be less lazy next time. :-)

--
Aaron Patterson
http://tenderlovemaking.com/

[matz (Yukihiro Matsumoto)]

• Assignee changed from matz (Yukihiro Matsumoto) to drbrain (Eric Hodel)

Commit the patch.

Matz.

[drbrain (Eric Hodel)]

• Status changed from Assigned to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r35759.
Aaron, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

• class.c (rb_mod_init_copy): Clear the cached inspect string of a
  dup'd anonymous module or class. [ruby-trunk - Bug #6454]
• test/ruby/test_module.rb (class TestModule): ditto