Project

General

Profile

Actions

Bug #5563

closed

Fix bug in drb tests if hostname does not resolve to a local IP

Added by jeremyevans0 (Jeremy Evans) over 12 years ago. Updated over 10 years ago.

Status:
Closed
Target version:
-
ruby -v:
ruby 1.9.3p0 (2011-10-30 revision 33570) [i386-openbsd]
Backport:
[ruby-core:40713]

Description

3 of the drb tests leave the hostname part of the druby URI empty instead of using localhost. When a hostname is not provided, ruby uses the system hostname, which usually resolves to a local IP address, but not always. This causes the tests to fail if the system hostname doesn't resolve to a local IP address. The tests also appear to hang, since the connection timeout is 100 seconds.

The attached patch fixes this case by using localhost as the hostname in the 3 tests that did not already do that, making them consistent with the other tests.


Files

test_drb_localhost.diff (1.24 KB) test_drb_localhost.diff jeremyevans0 (Jeremy Evans), 11/04/2011 01:57 AM

Updated by ko1 (Koichi Sasada) about 12 years ago

  • Assignee set to seki (Masatoshi Seki)
Actions #2

Updated by shyouhei (Shyouhei Urabe) about 12 years ago

  • Status changed from Open to Assigned

Updated by jeremyevans0 (Jeremy Evans) over 10 years ago

This bug can be closed. Bug #7311 was a duplicate of this bug with the exact same patch I provided, and the patch was applied at r41916.

Updated by zzak (zzak _) over 10 years ago

  • Status changed from Assigned to Closed

Thanks Jeremy!

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0