Bug #5251: Thread Change Breaks Windows Builds

• Status: Closed
• Assignee: kosaki (Motohiro KOSAKI)
• Target version: 1.9.3
• ruby -v: ruby 1.9.3dev (2011-08-26 revision 33077) [i386-mingw32]

[cfis (Charlie Savage)]

This commit:

Commit:4e9438bc9153f7a1f4ea0af85c8dbe359e1a55d8

Causes this error:

thread.c: In function rb_thread_select': thread.c:2685: warning: missing braces around initializer thread.c:2685: warning: (near initialization for fdsets[0]')
thread.c:2693: error: implicit declaration of function `rb_fd_copy'
make: *** [thread.o] Error 1

Using mingw, with this gcc:

gcc version 3.4.5 (mingw-vista special r3)

Note that in thread.c, rb_fd_copy is not defined for win32, and therefore, this breaks. Thus, this would break for msvc also it looks.

[kosaki (Motohiro KOSAKI)]

• Status changed from Open to Assigned
• Priority changed from Normal to 6

[kosaki (Motohiro KOSAKI)]

• Status changed from Assigned to Closed

This regression was caused by Bug#5229(rb_thread_select() rewritten) and fixed by r33128, r33130, r33131, r33132, r33133.

Thank you, Usa-san!

[normalperson (Eric Wong)]

Motohiro KOSAKI [e-mail] wrote:

This regression was caused by Bug#5229(rb_thread_select() rewritten)
and fixed by r33128, r33130, r33131, r33132, r33133.

Oops, sorry all, I'm a klutz :x