Bug #5229: [PATCH] thread.c (rb_thread_select): implement using rb_thread_fd_select

• Status: Closed
• Assignee: kosaki (Motohiro KOSAKI)
• Target version: 1.9.3
• ruby -v: ruby 1.9.4dev (2011-08-25 trunk 33057) [x86_64-linux]

[normalperson (Eric Wong)]

rb_thread_select() is deprecated, but should provide graceful
handling of interrupts for compatibility. rb_thread_fd_select()
provides graceful handling of interrupts and won't fail with
EINTR.

Added -ext- test case since no internal Ruby code paths uses
rb_thread_select() directly.

This is a regression from 1.9.2 and should be backported to 1.9.3, too

[ko1 (Koichi Sasada)]

• Assignee set to kosaki (Motohiro KOSAKI)

[kosaki (Motohiro KOSAKI)]

• Status changed from Open to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r33117.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

• thread.c (rb_thread_select): rewrite by using
  rb_thread_fd_select(). old one is EINTR unsafe.
  Patch by Eric Wong. [Bug #5229] [ruby-core:39102]

• test/-ext-/old_thread_select/test_old_thread_select.rb:
  a testcase for rb_thread_select().

• ext/-test-/old_thread_select/old_thread_select.c: ditto.

• ext/-test-/old_thread_select/depend: ditto.

• ext/-test-/old_thread_select/extconf.rb: ditto.