WEBrick returns improper response for malformed HTTP Request
When sending an improper HTTP request in the form of:
(with any valid or invalid HTTP verb), WEBrick returns:<TITLE>Internal Server Error</TITLE>
Internal Server Error¶undefined method `each' for nil:NilClass
WEBrick/1.3.1 (Ruby/1.9.2/2011-02-18) at localhost:3000
and then closes the connection, without sending any HTTP status headers or printing a correct '400 Bad Request' error page. This is because the @header variable wasn't set up properly, so @header is nil when a message is passed to it when handling the request. WEBrick's log on the server console will read similar to:
[2011-07-13 00:49:40] ERROR NoMethodError: undefined method
each' for nil:NilClass /Users/x/.rvm/rubies/ruby-1.9.2-p180/lib/ruby/1.9.1/webrick/httprequest.rb:154:in each'
meta_vars' /Users/x/.rvm/gems/ruby-1.9.2-p180/gems/rack-1.3.0/lib/rack/handler/webrick.rb:34:in service'
service' /Users/x/.rvm/rubies/ruby-1.9.2-p180/lib/ruby/1.9.1/webrick/httpserver.rb:70:in run'
/Users/x/.rvm/rubies/ruby-1.9.2-p180/lib/ruby/1.9.1/webrick/server.rb:183:in `block in start_thread'
(Where line 34 of rack/handler/webrick.rb is a simple
env = req.meta_vars)
This is reproducible in both 1.8.7 and 1.9.2.
A simple patch is attached to WEBrick's httprequest.rb that will allow the request to continue processing, fixing the 500 internal server error (and let the app decide how to handle the malformed request). In my testing with rack 1.3.0 & sinatra 1.2.6, this patch allowed the request complete normally.