Project

General

Profile

Actions

Bug #4726

closed

[doc] benchmark.rb

Added by sz (Sandor Szücs) about 11 years ago. Updated about 11 years ago.

Status:
Closed
Priority:
Normal
Target version:
ruby -v:
bf98fcefe1a9012731a351cb7c7cda74ae85e9ef
Backport:
[ruby-core:36274]

Description

Maybe you find it not useful, but to open up internals it would be nice to print internal docs.

This patch just removes :nodoc: comments.


Files

Actions #1

Updated by drbrain (Eric Hodel) about 11 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r31620.
Sandor, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • lib/benchmark.rb: Remove nodoc from Benchmark::Job and
    Benchmark::Report. Patch by Sandor Szücs. [Ruby 1.9 - Bug #4726]

Updated by mame (Yusuke Endoh) about 11 years ago

  • Status changed from Closed to Open

Hello,

Maybe you find it not useful, but to open up internals it would be nice to print internal docs.

Why do you want to open internal?
Generally, I don't think it is a good idea.
It limits future potential.

--
Yusuke Endoh

Updated by Eregon (Benoit Daloze) about 11 years ago

Hello,
Yusuke Endoh wrote:

Hello,

Maybe you find it not useful, but to open up internals it would be nice to print internal docs.

Why do you want to open internal?
Generally, I don't think it is a good idea.
It limits future potential.

--
Yusuke Endoh

I must agree, opening the internals would make harder sensible internal changes.

However, with :nodoc:, it is unclear which methods are available on the yielded object in Benchmark#{benchmark,bm,bmbm}.
(that is probably why I never saw anyone using #item, to which #report is an alias)

Thank you for pointing this out, but I would prefer to keep the internals undocumented to the end user for the moment.

Actions #4

Updated by drbrain (Eric Hodel) about 11 years ago

  • Status changed from Open to Closed

This issue was solved with changeset r31729.
Sandor, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • lib/benchmark.rb: Restore nodoc for Benchmark::Job and
    Benchmark::Report. [Ruby 1.9 - Bug #4726]

Updated by drbrain (Eric Hodel) about 11 years ago

If the details of the yielded object are a specification we should document them, but the benchmark maintainer needs to agree first.

Actions

Also available in: Atom PDF