Bug #3024: mkmf: Directory names with spaces cause invalid Makefiles to be generated

• Status: Closed
• Assignee: nobu (Nobuyoshi Nakada)
• Target version: 2.0.0
• ruby -v: ruby 1.9.1p378 (2010-01-10 revision 26273) [i386-darwin10.2.0]

[emerose (Sam Quigley)]

=begin
mkmf does not properly quote or escape directory names containing spaces, and thus creates invalid Makefiles. For example, a recent run of mkmf created a Makefile containing:

BINDIR = $(bindir)
RUBYCOMMONDIR = $(sitedir)$(target_prefix)
RUBYLIBDIR = /Users/sq/Code/Third Party/flint/vendor/gems/bcrypt-ruby-2.1.2/lib$(target_prefix)
RUBYARCHDIR = /Users/sq/Code/Third Party/flint/vendor/gems/bcrypt-ruby-2.1.2/lib$(target_prefix)

When make is run, it fails with the following errors:

[...]
make
Makefile:128: warning: overriding commands for target /Users/sq/Code/Third' Makefile:122: warning: ignoring old commands for target /Users/sq/Code/Third'
[...]
make install
Makefile:128: warning: overriding commands for target /Users/sq/Code/Third' Makefile:122: warning: ignoring old commands for target /Users/sq/Code/Third'
mkdir -p /Users/sq/Code/Third
/opt/local/bin/ginstall -c -m 0755 bcrypt_ext.bundle /Users/sq/Code/Third Party/flint/vendor/gems/bcrypt-ruby-2.1.2/lib
/opt/local/bin/ginstall: omitting directory `/Users/sq/Code/Third'
make: *** [Party/flint/vendor/gems/bcrypt-ruby-2.1.2/lib/bcrypt_ext.bundle] Error 1

This issue (or something very similar) was reported as Ruby bug #2308 on 2005-08-25 here: http://rubyforge.org/tracker/index.php?func=detail&aid=2308&group_id=426&atid=1698
=end

[mame (Yusuke Endoh)]

=begin
Hi,

2010/3/27 Sam Quigley [e-mail]:

mkmf does not properly quote or escape directory names containing spaces, and thus creates invalid Makefiles.

Thank you for your reporting and investigating.

I think this is absolutely a bug. But, I'm afraid that it takes
some time to fix and make it stable this kind of bugs.
Even if it seems to be fixed, hard-to-find regression bug might be
included, which leads to build failure of existing libraries on
some envirionments.

In addition, this issue can be avoided easily by avoiding such a
path that is likely to cause problem.

So, I think we should not fix it hurriedly. I suggest to defer
this ticket to 1.9.3.

--
Yusuke ENDOH [e-mail]

=end

[mame (Yusuke Endoh)]

• Target version set to 2.0.0

=begin

=end

[naruse (Yui NARUSE)]

• Status changed from Open to Assigned
• Assignee set to nobu (Nobuyoshi Nakada)

[nahi (Hiroshi Nakamura)]

• Target version changed from 2.0.0 to 1.9.3

[mame (Yusuke Endoh)]

• Priority changed from Normal to 5
• Target version changed from 1.9.3 to 2.0.0

Nobu, could you check this?

--
Yusuke Endoh [e-mail]

[nobu (Nobuyoshi Nakada)]

• Status changed from Assigned to Closed