Project

General

Profile

Actions

Bug #2974

closed

WEBrick error in httpstatus

Added by orgads (Orgad Shaneh) about 14 years ago. Updated about 13 years ago.

Status:
Closed
ruby -v:
ruby 1.8.7 (2010-01-10 patchlevel 249) [i486-linux]
[ruby-core:28692]

Description

=begin
HTTPStatus has some Status classes, which derive from StandardError < Exception.

In Status::initialize, message (which should return a string) is defined to self.class (which is not a string). When the exception is raised, trying to read its message and manipulate it as a string fails.

This issue causes redmine to behave strange when it raises HttpNotModified exception (http 304). It crashes on HTMLUtils escape, and thus return http 500 internal error, leaving the browser without the requested file (which is .js or .css).

I'm attaching a patch I wrote for that. I don't have any experience with ruby, so I just did what felt right. Feel free to modify it as needed :)
=end


Files

httpstatus.patch (386 Bytes) httpstatus.patch orgads (Orgad Shaneh), 03/17/2010 02:27 AM
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0