Project

General

Profile

Actions

Feature #20876

closed

Introduce `Fiber::Scheduler#blocking_operation_wait` to avoid stalling the event loop.

Added by ioquatix (Samuel Williams) 15 days ago. Updated 1 day ago.

Status:
Closed
Assignee:
-
Target version:
-
[ruby-core:119772]

Description

This is an evolution of the previous proposal: https://bugs.ruby-lang.org/issues/20855

Background

The current Fiber Scheduler performance can be significantly impacted by blocking operations that cannot be deferred to the event loop, particularly in high-concurrency environments where Fibers rely on non-blocking operations for efficient task execution.

Proposal

Pull Request: https://github.com/ruby/ruby/pull/12016

We will introduce a new fiber scheduler hook called blocking_operation_work:

class MySchduler
  # ...
  def blocking_operation_wait(work)
    # Example (trivial) implementation:
    Thread.new(&work).join
  end
end

We introduce a new flag for rb_nogvl: RB_NOGVL_OFFLOAD_SAFE which indicates that rb_nogvl(func, ...) is a blocking operation that is safe to execute on a different thread or thread pool (or some other context).

When a C extension invokes rb_nogvl(..., RB_NOGVL_OFFLOAD_SAFE), and a fiber scheduler is available, all the arguments will be saved into a instance of a callable object (at this time a Proc) called work and passed to the blocking_operation_wait fiber scheduler hook. When work is #called, it will execute rb_nogvl again with all the same arguments.

The fiber scheduler can decide how to execute that work, e.g. on a separate thread or thread pool, to mitigate the performance impact of the blocking operation on the event loop.

Cancellation

rb_nogvl takes several arguments, a func for the actual work, and unblock_func to cancel func if possible. These arguments are preserved in the work proc, and cancellation works the same. However, some extra effort may be required in the fiber scheduler hook, e.g.

class MySchduler
  # ...
  def blocking_operation_wait(work)
    thread = Thread.new(&work)

    thread.join
    thread = nil
  ensure
    thread&.kill
  end
end

Example

Using the branch of async gem: https://github.com/socketry/async/pull/352/files and enabling zlib deflate to use this feature, the following performance improvement was achieved:

require "zlib"
require "async"
require "benchmark"

DATA = Random.new.bytes(1024*1024*100)

duration = Benchmark.measure do
  Async do
    10.times do
      Async do
        Zlib.deflate(DATA)
      end
    end
  end
end

# Ruby 3.3.4: ~16 seconds
# Ruby 3.4.0 + PR: ~2 seconds.

To run this benchmark yourself, you must compile CRuby with these two PRs:

In addition, enable RB_NOGVL_OFFLOAD_SAFE in zlib.c's call to rb_nogvl.

Then, use this branch of async: https://github.com/socketry/async/pull/352


Files

clipboard-202411071531-gw8tg.png (200 KB) clipboard-202411071531-gw8tg.png ioquatix (Samuel Williams), 11/07/2024 02:31 AM
Actions #1

Updated by ioquatix (Samuel Williams) 15 days ago

  • File clipboard-202411071018-ytvzs.png added
  • Description updated (diff)
Actions #2

Updated by ioquatix (Samuel Williams) 15 days ago

  • Description updated (diff)
Actions #3

Updated by ioquatix (Samuel Williams) 15 days ago

  • File deleted (clipboard-202411070126-fbqpn.png)
Actions #4

Updated by ioquatix (Samuel Williams) 15 days ago

  • Description updated (diff)
Actions #5

Updated by ioquatix (Samuel Williams) 15 days ago

  • Description updated (diff)
Actions #7

Updated by ioquatix (Samuel Williams) 15 days ago

  • File deleted (clipboard-202411071018-ytvzs.png)
Actions #8

Updated by ioquatix (Samuel Williams) 15 days ago

  • Description updated (diff)

Updated by ko1 (Koichi Sasada) 2 days ago

go ahead.

Actions #11

Updated by Anonymous 1 day ago

  • Status changed from Open to Closed

Applied in changeset git|9c268302bfb4890d3757caa60981802a88bfbd89.


Introduce Fiber::Scheduler#blocking_operation_wait. (#12016)

Redirect rb_nogvl blocking operations to the fiber scheduler if possible
to prevent stalling the event loop.

[Feature #20876]

Actions

Also available in: Atom PDF

Like1
Like0Like0Like0Like0Like0Like0Like0Like0Like0Like0Like0