Feature #2084: Method#source_location and Methods Created with `attr`

• Status: Closed
• Assignee: wanabe (_ wanabe)
• Target version: 1.9.2

[runpaint (Run Paint Run Run)]

=begin
$ cat /tmp/attr.rb
class C
attr :a
end

p C.instance_methods(false)
p C.instance_method(:a).source_location

$ ruby -v /tmp/attr.rb
ruby 1.9.2dev (2009-09-11) [i686-linux]
[:a]
nil

Is it feasible to have Method#source_location work with methods created with attr(and friends)? Given that a common use for this feature is to extract documentation, it would be helpful if such methods could be located by introspection.
=end

[wanabe (_ wanabe)]

• File save_attr_loc.patch save_attr_loc.patch added

=begin
I wrote a patch. How about this?
=end

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Assigned
• Assignee set to yugui (Yuki Sonoda)

=begin

=end

[mame (Yusuke Endoh)]

• Priority changed from 3 to Normal
• Target version set to 1.9.2

=begin
Hi,

I wrote a patch. How about this?

+1, and I confirmed it passes make check and RubySpec.

Matz or Yugui, could you approve this?

--
Yusuke Endoh [e-mail]
=end

[mame (Yusuke Endoh)]

• Assignee changed from yugui (Yuki Sonoda) to wanabe (_ wanabe)

=begin
Hi,

Matz or Yugui, could you approve this?

Yugui has agreed with this feature on IRC.
But she said she had no responsibility for Method#source_location.
(I had misunderstood that she had committed it)

Well, because this feature is trivial, I guess anyone won't disagree.
Wanabe, could you apply your patch?
If you are reluctant to commit it without explicit approval, I'll
commit it on my own responsibility.

--
Yusuke Endoh [e-mail]
=end

[wanabe (_ wanabe)]

=begin

If you are reluctant to commit it without explicit approval, I'll
commit it on my own responsibility.

Many thanks for your concern.
I'll apply it soon.
=end

[wanabe (_ wanabe)]

• Status changed from Assigned to Closed
• % Done changed from 0 to 100

=begin
This issue was solved with changeset r27016.
Run Paint, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

=end