Bug #20776: [PRISM] Pattern matching syntax error message

• Status: Closed
• Assignee: prism
• Target version: -
• Backport: 3.1: DONTNEED, 3.2: DONTNEED, 3.3: UNKNOWN

[nobu (Nobuyoshi Nakada)]

Syntax error is fine, but is really expecting end-of-input there?

$ ruby -v -e '1 => $g'
ruby 3.4.0dev (2024-10-01T14:59:58Z master 169a5ee99e) +PRISM [arm64-darwin23]
-e:1: warning: possibly useless use of a variable in void context
-e: -e:1: syntax errors found (SyntaxError)
> 1 | 1 => $g
    |      ^~ unexpected global variable, expecting end-of-input
    |      ^~ expected a pattern expression after `=>`
  2 | 

And the line 2 is not in the input.

[nobu (Nobuyoshi Nakada)]

• Assignee set to prism
• Backport changed from 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN to 3.1: DONTNEED, 3.2: DONTNEED, 3.3: UNKNOWN

The same code segfaulted crashed due to "Unexpected node type" in 3.3.
Probably some backports are needed.

[kddnewton (Kevin Newton)]

What's happening with the error message is that it's seeing the $g and determining that it's not a valid pattern, so it assumes the pattern is missing. Then it's determining that there is no statement delimiter (newline or semicolon) between the statements, so it's saying it expected and end-of-input. Then it's finding the $g at the beginning of the next expression, so it's warning that it's possibly useless. Effectively it's parsing it like:

1 => <missing>
$g

I'm happy to change the error message to whatever would make that more clear.

The second newline is in there because it looked weird having errors hang off the end without another line indicating where the input ended, but I can remove that.

[hsbt (Hiroshi SHIBATA)]

• Status changed from Open to Assigned

[tenderlovemaking (Aaron Patterson)]

• Status changed from Assigned to Feedback

@nobu (Nobuyoshi Nakada) are you satisfied with @kddnewton's response? I'm not sure what we need to do to close this issue.

Thanks.

[nobu (Nobuyoshi Nakada)]

• Status changed from Feedback to Closed

Thank you, I confirmed that no ghost line appears now.