Misc #20683
closedPropose @ono-max as a committer
Description
I'd like to propose @ono-max (Naoto Ono) as a committer.
He has contributed to Ruby's test framework, starting with the introduction of Launchable (#20254, #20661).
Also he has been an ongoing contributor to the investigation and correction of flaky failures in Ruby's CI (#20682).
A number of his PRs have already been merged:
$ git log --author=onoto --oneline | wc -l
28
And I have merged my fixes based on his investigation. TBH, It is easier for me if he has a commit bit.
Incidentally, he also contributes to the debug gem.
$ git log --author=onoto --oneline | wc -l
86
@matz (Yukihiro Matsumoto) What do you think?
Updated by mame (Yusuke Endoh) 3 months ago
I forgot to mention that he has expressed his willingness to accept committer's proposal here: https://bugs.ruby-lang.org/issues/20682#note-3
Updated by hsbt (Hiroshi SHIBATA) 3 months ago
- Status changed from Open to Assigned
- Assignee set to matz (Yukihiro Matsumoto)
+1
Our test suite and CI are complex and complicated. We need more maintainer for that.
Updated by matz (Yukihiro Matsumoto) 3 months ago
Approved.
Matz.
Updated by hsbt (Hiroshi SHIBATA) 3 months ago
- Assignee changed from matz (Yukihiro Matsumoto) to hsbt (Hiroshi SHIBATA)
@ono-max (Naoto Ono) Can you give Required and Optional information of https://github.com/ruby/ruby/wiki/Committer-How-To#how-to-register-you-as-a-committer to cvs-admin@ruby-lang.org
?
Updated by ono-max (Naoto Ono) 3 months ago
Yes. I sent the email to the address.
Updated by hsbt (Hiroshi SHIBATA) 3 months ago
- Status changed from Assigned to Closed
I've finished account setup for ono-san.