Feature #20524
closedmswin and gmp
Description
Currently, the vcpkg.json
file exists, and it can be used to specify what MSFT/vcpkg packages to install, and also a repo commit, which will determine the what package versions are used. The file lists the gmp package.
-
To use the gmp package in mswin,
win32/configure.bat
shows an option of--with-gmp
. This option is not used in thewindows.yml
workflow file, nor is it mentioned indoc/windows.md
. -
When using the option, the build fails when compiling
bignum.c
, as it can’t findgmp.h
. It appears the vcpkg include folder is not being passed tocl
?
So, it seems a few things are amiss. gmp
was added a long time ago. With current mswin builds, will gmp
improve Bignum
’s performance? Is that unknown? If there are benchmarks to determine this, I could certainly run them…
Updated by nobu (Nobuyoshi Nakada) 2 months ago
- Tracker changed from Misc to Bug
- Backport set to 3.1: REQUIRED, 3.2: REQUIRED, 3.3: REQUIRED
Updated by nobu (Nobuyoshi Nakada) 2 months ago
- Status changed from Open to Closed
Applied in changeset git|065190a973c9534b93e3ff99b789bcc945032dfd.
[Bug #20524] win32: Try to configure GMP if available
Updated by nagachika (Tomoyuki Chikanaga) 2 months ago
- Backport changed from 3.1: REQUIRED, 3.2: REQUIRED, 3.3: REQUIRED to 3.1: WONTFIX, 3.2: WONTFIX, 3.3: REQUIRED
I think this is a kind of new feature of ruby build system. I won't backport it to 3.2 branch. It's up to kokubun-san for 3.3 branch.
Updated by k0kubun (Takashi Kokubun) 2 months ago
- Tracker changed from Bug to Feature
- Backport deleted (
3.1: WONTFIX, 3.2: WONTFIX, 3.3: REQUIRED)
seems like a new feature to me too. I won't backport it to 3.3.