Bug #20111: `defined?` returns `expression` for assignment operators combined with fully qualified constants

• Status: Closed
• Assignee: -
• Target version: -
• ruby -v: 3.2.2
• Backport: 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN

[andrykonchin (Andrew Konchin)]

defined? doesn't consider &&=, ||= and other ...= operators as assignment:

defined?(A::B += 1) # => "expression"
defined?(A::B &&= true) # => "expression"
defined?(A::B ||= true) # => "expression"

But considers as assignment ordinal assignment:

defined?(A::B = 1) # => "assignment"

Wondering if it's expected behaviour.

[Eregon (Benoit Daloze)]

At least it seems inconsistent with defined?(A += 1) and defined?(a += 1) which are both "assignment"

[andrykonchin (Andrew Konchin)]

• Description updated (diff)

[jeremyevans0 (Jeremy Evans)]

I submitted a pull request to fix this: https://github.com/ruby/ruby/pull/9476

• Status changed from Open to Closed

Applied in changeset git|ef751252711ca7ecabb3e4ad9214fa0d1d63608a.

---

Make defined? for op asgn expressions to constants use "assignment"

Previously, it used "expression", as that was the default. However,
op asgn expressions to constants use the NODE_OP_CDECL, so recognize
that node type as assignement.

Fixes [Bug #20111]

[ko1 (Koichi Sasada)]

Just curious, who cares the difference?

[Eregon (Benoit Daloze)]

@ko1 (Koichi Sasada) Just inconsistency discovered while implementing defined? for these various constructs.