Feature #1927: rb_w32_readdir seems to be superseded by rb_w32_readdir_with_enc

• Status: Closed
• Assignee: usa (Usaku NAKAMURA)
• Target version: 2.0.0

[vo.x (Vit Ondruch)]

=begin
Function rb_w32_readdir seems to be superseded by function rb_w32_readdir_with_enc. It renders rb_w32_readdir useless and it should be removed from source code to avoid confusion.

Or better, rb_w32_readdir_with_enc should be renamed back to rb_w32_readdir.
=end

[usa (Usaku NAKAMURA)]

• Status changed from Open to Assigned
• Assignee set to usa (Usaku NAKAMURA)
• Target version set to 2.0.0

=begin
ruby 1.9.1-p0 has rb_w32_readdir(), so we cannot remove it or change its signature to secure binary compatibility.
There might be a chance when the binary version will be updated.
=end

[usa (Usaku NAKAMURA)]

• Priority changed from Normal to 3

=begin

=end

[usa (Usaku NAKAMURA)]

• Description updated (diff)

I'll be remove it (and other useless APIs) before code freeze.

[mame (Yusuke Endoh)]

• Priority changed from 3 to 5

Usa-san, is there any reason for the task to wait immediately before code freeze?
If there is no reason, and if you are willing to do the task for 2.0, please do so asap.

--
Yusuke Endoh [e-mail]

[usa (Usaku NAKAMURA)]

• Status changed from Assigned to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r38534.
Vit, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

• win32/{dir.h,win32.c} (rb_w32_readdir): removed old rb_w32_readdir()
  and renamed from rb_w32_readdir_with_enc().
  [ruby-core:24864] [Feature #1927]

• dir.c (READDIR): follow above change.