Bug #17011: BigDecimal .to_s should not use ASCII-8BIT

• Status: Closed
• Assignee: nobu (Nobuyoshi Nakada)
• Target version: -
• ruby -v: ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux-gnu]
• Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN

[david.drakard (David Drakard)]

BigDecimal#to_s returns a String in ASCII-8BIT encoding. This is inconvenient in situations where the encoding determines program behaviour, since ASCII-8BIT is a special encoding that implies binary (non-textual) data, it can require an explicit conversion.

BigDecimal#to_s should either use the currently active encoding, or it should use US-ASCII like Integer#to_s.

Recreation script:

# encoding: utf-8
Encoding.default_internal = Encoding::UTF_8
Encoding.default_external = Encoding::UTF_8
require 'bigdecimal'
puts BigDecimal('2').to_s.encoding

Desired output: US-ASCII or UTF-8

Actual output: ASCII-8BIT

[david.drakard (David Drakard)]

• Description updated (diff)

[byroot (Jean Boussier)]

I submitted a PR for it: https://github.com/ruby/ruby/pull/3291

[nobu (Nobuyoshi Nakada)]

• Description updated (diff)

Could you submit this to https://github.com/ruby/bigdecimal?

[byroot (Jean Boussier)]

Sure.

[byroot (Jean Boussier)]

Actually, it's already been fixed upstream: https://github.com/ruby/bigdecimal/pull/160

Maybe the Ruby spec part of my PR is still useful. I'll submit it to https://github.com/ruby/spec

[Eregon (Benoit Daloze)]

How should we proceed to include that fix in CRuby master?

[Eregon (Benoit Daloze)]

• Status changed from Open to Closed
• Assignee set to nobu (Nobuyoshi Nakada)

@nobu (Nobuyoshi Nakada) picked that fix in https://github.com/ruby/ruby/commit/6a826eb4b08484cb3b6279da905f5b9e03e0df5f
(details at https://github.com/ruby/spec/pull/778#issuecomment-655420419)
Thanks!