Feature #16963
closedRemove English.rb from Ruby 2.8/3.0
Added by hsbt (Hiroshi SHIBATA) over 5 years ago. Updated over 2 years ago.
Description
English.rb is no longer maintained by ruby core team.
Can we remove it from our repository? The users can install if from rubygems.org now.
Updated by retro (Josef Šimánek) over 5 years ago
Actions
#1
[ruby-core:98827]
I'm all in for this since this one will help to "normalize" standard library naming (this one is also having "exotic" file name with capital first letter).
Updated by hsbt (Hiroshi SHIBATA) over 5 years ago
Actions
#2
[ruby-core:98850]
- Status changed from Open to Assigned
mame@gem-codesearch:~$ csearch "require 'English'" | wc -l
866
mame@gem-codesearch:~$ csearch "require \"English\"" | wc -l
273
We found the usage of English.rb like capybara that is the famous gem. I have a bit of aware to affect this proposal.
Updated by deivid (David Rodríguez) over 5 years ago
Actions
#3
[ruby-core:98858]
I'm surprised by the low usage you found anyways, since rubocop
and its style guide recommend English
and enforce it by default. Honestly, I'd like all English names to be there by default without having to require anything.
Updated by hsbt (Hiroshi SHIBATA) over 5 years ago
Actions
#4
- Related to Feature #14138: Define English.rb aliases by default and eliminate the library added
Updated by hsbt (Hiroshi SHIBATA) over 5 years ago
Actions
#5
[ruby-core:98864]
@deivid
See #14138 . We have a plan to remove it at Ruby 3.
Updated by deivid (David Rodríguez) over 5 years ago
Actions
#6
[ruby-core:98866]
Nice, I didn't know that. Something I don't quite get is, if the functionality of English
will be the default (in ruby 2.8, I guess?), what's the point of gemifying it?
Updated by Eregon (Benoit Daloze) over 5 years ago
Actions
#7
[ruby-core:98872]
I think we should define these aliases in core, and then English.rb does nothing.
Removing it from the standard library seems too incompatible to me.
Updated by deivid (David Rodríguez) over 5 years ago
Actions
#8
[ruby-core:98883]
Agreed!
We should at least add a warning on top of English.rb
for a full release cycle before removing it.
Updated by hsbt (Hiroshi SHIBATA) over 2 years ago
Actions
#9
- Related to Feature #19351: Promote bundled gems at Ruby 3.3 added
Updated by hsbt (Hiroshi SHIBATA) over 2 years ago
Actions
#10
[ruby-core:111935]
- Status changed from Assigned to Closed
I withdraw this proposal. We need to consider another deprecate plan.