Feature #16963
closed
Remove English.rb from Ruby 2.8/3.0
Added by hsbt (Hiroshi SHIBATA) over 4 years ago.
Updated almost 2 years ago.
Description
English.rb is no longer maintained by ruby core team.
Can we remove it from our repository? The users can install if from rubygems.org now.
I'm all in for this since this one will help to "normalize" standard library naming (this one is also having "exotic" file name with capital first letter).
- Status changed from Open to Assigned
mame@gem-codesearch:~$ csearch "require 'English'" | wc -l
866
mame@gem-codesearch:~$ csearch "require \"English\"" | wc -l
273
We found the usage of English.rb like capybara that is the famous gem. I have a bit of aware to affect this proposal.
I'm surprised by the low usage you found anyways, since rubocop
and its style guide recommend English
and enforce it by default. Honestly, I'd like all English names to be there by default without having to require anything.
- Related to Feature #14138: Define English.rb aliases by default and eliminate the library added
Nice, I didn't know that. Something I don't quite get is, if the functionality of English
will be the default (in ruby 2.8, I guess?), what's the point of gemifying it?
I think we should define these aliases in core, and then English.rb does nothing.
Removing it from the standard library seems too incompatible to me.
Agreed!
We should at least add a warning on top of English.rb
for a full release cycle before removing it.
- Status changed from Assigned to Closed
I withdraw this proposal. We need to consider another deprecate plan.
Also available in: Atom
PDF
Like0
Like0Like0Like0Like0Like0Like0Like0Like0Like0Like0