Project

General

Profile

Bug #16697

Hash.ruby2_keywords_hash?(value) should support any object

Added by Eregon (Benoit Daloze) 3 months ago.

Status:
Open
Priority:
Normal
Assignee:
-
Target version:
ruby -v:
ruby 2.8.0dev (2020-02-28T14:32:56Z master f7be85a2b7) [x86_64-linux]
[ruby-core:97554]

Description

But currently it raises, which makes it needlessly inconvenient to use:

> Hash.ruby2_keywords_hash?({})
=> false
> Hash.ruby2_keywords_hash?("hello")
Traceback (most recent call last):
        5: from /home/eregon/.rubies/ruby-trunk/bin/irb:23:in `<main>'
        4: from /home/eregon/.rubies/ruby-trunk/bin/irb:23:in `load'
        3: from /home/eregon/prefix/ruby-trunk/lib/ruby/gems/2.8.0/gems/irb-1.2.3/exe/irb:11:in `<top (required)>'
        2: from (irb):4
        1: from (irb):4:in `ruby2_keywords_hash?'
TypeError (wrong argument type String (expected Hash))

See https://github.com/ruby/ruby/pull/2966/files#r394741112 for a motivating example.

I'd like to suggest backporting this to 2.7 too.

No data to display

Also available in: Atom PDF