Project

General

Profile

Feature #16233

winruby UTF8 Fallback for no CodePage

Added by gabuscus (Gabriel Nagy) 6 months ago. Updated 3 months ago.

Status:
Open
Priority:
Normal
Target version:
[ruby-core:95196]

Description

This is to deal specifically with setting the Region to Arabic which
sets the codepage to 720. This codepage isn't recognised by Ruby which
causes it to fail during initialisation when setting up LOCALE.

This patch to Ruby is necessary to handle languages/regions on windows
where the codepage is not supported by Ruby such as Arabic which uses
codepage 720.
If the codepage is not found, the Locale falls back to UTF8.

This is a well known Ruby/Ruby on Rails issue which is described at
https://stackoverflow.com/questions/22815542/rails4-unknown-encoding-name-cp720

Opened PR: https://github.com/ruby/ruby/pull/2518


Files

windows_nocodepage_utf8_fallback_r2.5.patch (946 Bytes) windows_nocodepage_utf8_fallback_r2.5.patch patch to fix the issue gabuscus (Gabriel Nagy), 10/03/2019 07:27 AM
#1

Updated by gabuscus (Gabriel Nagy) 6 months ago

  • Description updated (diff)

Updated by duerst (Martin Dürst) 6 months ago

If codepage 720 is not supported, then we should look at supporting it.

Updated by gabuscus (Gabriel Nagy) 6 months ago

duerst (Martin Dürst) wrote:

If codepage 720 is not supported, then we should look at supporting it.

fair point, however investigation on this Puppet ticket: https://tickets.puppetlabs.com/browse/PA-2191 concluded that falling back to UTF-8 fixes the issue (for codepage 720 at least). we could also check the codepage when catching the ArgumentError so we fallback only in that case

edit: also I'm not sure what does adding a new codepage entail? I agree that would be the cleaner solution

#4

Updated by hsbt (Hiroshi SHIBATA) 3 months ago

  • Tags set to patch, win, encoding

Updated by naruse (Yui NARUSE) 3 months ago

  • Backport deleted (2.5: UNKNOWN, 2.6: UNKNOWN)
  • ruby -v deleted (2.6.3)
  • Target version set to 2.8
  • Assignee set to duerst (Martin Dürst)
  • Tracker changed from Bug to Feature

Updated by duerst (Martin Dürst) 3 months ago

Will do, but probably not very soon, because it's now the most busy time of the year at work, sorry.

Some notes: For the encoding (onigX), windows-1256 is a replica of iso-8859-6. But windows-1256 is much more complete, while iso-8859-6 has many unassigned codepoints, so it may be a good idea to fix this if we get around to it.

Just adding an alias 'CP720' for windows-1256 is much easier.

Also available in: Atom PDF