Misc #16089: Explain that github prs do not get merged

• Status: Closed
• Assignee: -

[dmr (daniel radetsky)]

The fact that fixes which are accepted still get closed, rather than being merged, is confusing. The (easiest) solution is to modify

https://bugs.ruby-lang.org/projects/ruby/wiki/HowToContribute

Change submit section to something like

"Pull request to https://github.com/ruby/ruby is acceptable for tiny fixes. But pull requests which need discussions will be ignored unless you create a redmine ticket. Note that even accepted pull requests are closed, not merged, because github is not the canonical ruby repo."

I'd do this myself, but either I'm not allowed to edit this page, or I can't figure out how.

This was discussed a bit in

https://github.com/ruby/ruby/pull/2323

[dmr (daniel radetsky)]

I actually realize that this is wrong & that technically it's "accepted pull requests are often closed, not merged, because..."

[jeremyevans0 (Jeremy Evans)]

• Status changed from Open to Closed

I've updated the wiki to reflect this. If you think additional changes are needed, please reply.

[k0kubun (Takashi Kokubun)]

Good news is, yesterday I discussed this issue with @mame (Yusuke Endoh) who was the person opposed to having a merge commit, and we got an idea to solve his problems.

Once it's implemented (work in progress; @mame (Yusuke Endoh) implemented one, and I'm going to implement the other piece), we'd be able to create a merge commit. By just using a merge commit, your pull requests will not be "Closed" but "Merged" on GitHub too, without requiring to rebase a pull request when it's not up to date. So I hope you'll like our workflow a little bit more after that.