Bug #15284: Unintentional warnings with node.h

• Status: Closed
• Priority: Normal
• Assignee: nobu (Nobuyoshi Nakada)
• Target version: -
• Backport: 2.3: REQUIRED, 2.4: DONE, 2.5: DONE

[hsbt (Hiroshi SHIBATA)]

Recently, I got the following warnings with build time.

parse.c:4720:14: warning: incompatible pointer types passing 'FILE *' (aka 'struct __sFILE *') to parameter of type 'struct parser_params *' [-Wincompatible-pointer-types]
  YYFPRINTF (yyo, "%s %s (",
             ^~~
../node.h:437:57: note: passing argument to parameter 'parser' here
PRINTF_ARGS(void rb_parser_printf(struct parser_params *parser, const char *fmt, ...), 2, 3);
                                                        ^
parse.c:4724:14: warning: incompatible pointer types passing 'FILE *' (aka 'struct __sFILE *') to parameter of type 'struct parser_params *' [-Wincompatible-pointer-types]
  YYFPRINTF (yyo, ": ");
             ^~~
../node.h:437:57: note: passing argument to parameter 'parser' here
PRINTF_ARGS(void rb_parser_printf(struct parser_params *parser, const char *fmt, ...), 2, 3);
                                                        ^
parse.c:4726:14: warning: incompatible pointer types passing 'FILE *' (aka 'struct __sFILE *') to parameter of type 'struct parser_params *' [-Wincompatible-pointer-types]
  YYFPRINTF (yyo, ")");
             ^~~
../node.h:437:57: note: passing argument to parameter 'parser' here
PRINTF_ARGS(void rb_parser_printf(struct parser_params *parser, const char *fmt, ...), 2, 3);

Maybe, It caused by bison version.

> bison --version
bison (GNU Bison) 3.2

[nobu (Nobuyoshi Nakada)]

• Related to Bug #15297: Appveyor - test-all failures & build warnings - bison 3.1 vs 3.2 ? added

[nobu (Nobuyoshi Nakada)]

• Status changed from Assigned to Closed

Applied in changeset trunk|r65667.

---

Fix for bison 3.2 [Bug #15284]

[yui-knk (Kaneko Yuichiro)]

JFYI: It seems this commit on bison http://git.savannah.gnu.org/cgit/bison.git/commit/?id=e7b709ab0b00244f87f53e60bc2d0ad6b32f0c23 changed yyoutput to yyo. And this change on bison has been introduced to version 3.2.

Ref: http://lists.gnu.org/archive/html/bison-patches/2018-10/msg00083.html

[nobu (Nobuyoshi Nakada)]

• Backport changed from 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN to 2.3: REQUIRED, 2.4: REQUIRED, 2.5: REQUIRED

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 2.3: REQUIRED, 2.4: REQUIRED, 2.5: REQUIRED to 2.3: REQUIRED, 2.4: REQUIRED, 2.5: DONE

ruby_2_5 r66285 merged revision(s) 65667.

[usa (Usaku NAKAMURA)]

• Backport changed from 2.3: REQUIRED, 2.4: REQUIRED, 2.5: DONE to 2.3: REQUIRED, 2.4: DONE, 2.5: DONE

ruby_2_4 r66970 merged revision(s) 65667.