Bug #15087: Segmentation fault with splat and block

• Status: Closed
• Assignee: -
• Target version: -
• ruby -v: 2.5.0, 2.5.1, 2.6.0dev (2018-09-07 trunk 64656)
• Backport: 2.3: DONTNEED, 2.4: DONTNEED, 2.5: DONE

[jacobevelyn (Jacob Evelyn)]

The following code produces segmentation faults in Ruby 2.5.0, 2.5.1, and 2.6.0dev (2018-09-07 trunk 64656). This code worked in Ruby 2.4.1.

test_proc = Proc.new { "test" }
def foo(bar: 1, &block)
  yield
end
foo(**{}, &test_proc)

I've attached the crash reports for both Ruby 2.6.0dev (2018-09-07 trunk 64656) and 2.5.1. Let me know if there's anything else I can provide.

[mame (Yusuke Endoh)]

• Related to Bug #15052: must not optimize `foo(**{})` out added

[mame (Yusuke Endoh)]

Good catch. My patch for #15052 will fix this issue.

[mame (Yusuke Endoh)]

mame (Yusuke Endoh) wrote:

Good catch. My patch for #15052 will fix this issue.

We have never agreed with how to fix #15052 yet. Nobu is working on this issue without behavior change.

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Closed

Applied in changeset trunk|r64786.

---

parse.y: fix block passing with empty kwargs

• parse.y (arg_blk_pass): preceeding arguments node may be NULL when
  an empty keyword argument hash splat is optimized away.
  [ruby-core:88890] [Bug #15087]

[RubyBugs (A Nonymous)]

This is still crashing in Ruby 2.5.3. Is this going to ever be fixed in Ruby 2.5 series?

[nobu (Nobuyoshi Nakada)]

• Backport changed from 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN to 2.3: DONTNEED, 2.4: DONTNEED, 2.5: REQUIRED

Sorry, I've missed filling the Backport.

[nagachika (Tomoyuki Chikanaga)]

• Backport changed from 2.3: DONTNEED, 2.4: DONTNEED, 2.5: REQUIRED to 2.3: DONTNEED, 2.4: DONTNEED, 2.5: DONE

ruby_2_5 r65579 merged revision(s) 64786.

[RubyBugs (A Nonymous)]

Hurray! Confirmed that this no longer crashes and works as expected on 2.5.4 and 2.6.2