Project

General

Profile

Bug #14375

3 Spec failures building MinGW 2018-01-19 trunk 61950

Added by MSP-Greg (Greg L) over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Target version:
-
ruby -v:
ruby 2.6.0dev (2018-01-19 trunk 61950) [x64-mingw32]
[ruby-core:84933]

Description

Below are the results of spec tests for 61964. The previous build, ruby 2.6.0dev (2018-01-19 trunk 61949) [x64-mingw32] did not have these failures.

Thanks, Greg

1)
File#chmod always succeeds with any numeric values FAILED
Expected to not get Exception
but got RangeError (integer -1073741824 too small to convert to `unsigned short')
spec/ruby/core/file/chmod_spec.rb:23:in `block (4 levels) in <top (required)>'
spec/ruby/core/file/chmod_spec.rb:22:in `each'
spec/ruby/core/file/chmod_spec.rb:22:in `block (3 levels) in <top (required)>'
spec/ruby/core/file/chmod_spec.rb:3:in `<top (required)>'

2)
File.chmod always succeeds with any numeric values FAILED
Expected to not get Exception
but got RangeError (integer -1073741824 too small to convert to `unsigned short')
spec/ruby/core/file/chmod_spec.rb:131:in `block (4 levels) in <top (required)>'
spec/ruby/core/file/chmod_spec.rb:130:in `each'
spec/ruby/core/file/chmod_spec.rb:130:in `block (3 levels) in <top (required)>'
spec/ruby/core/file/chmod_spec.rb:111:in `<top (required)>'

3)
File.umask always succeeds with any integer values FAILED
Expected to not get Exception
but got RangeError (integer -1073741824 too small to convert to `unsigned short')
spec/ruby/core/file/umask_spec.rb:37:in `block (3 levels) in <top (required)>'
spec/ruby/core/file/umask_spec.rb:36:in `each'
spec/ruby/core/file/umask_spec.rb:36:in `block (2 levels) in <top (required)>'
spec/ruby/core/file/umask_spec.rb:3:in `<top (required)>'

Files

chmod_spec.rb (7.3 KB) chmod_spec.rb MSP-Greg (Greg L), 01/19/2018 09:31 PM
spec-ruby-core-file-chmod_umask.patch (5.04 KB) spec-ruby-core-file-chmod_umask.patch MSP-Greg (Greg L), 01/20/2018 03:50 AM
umask_spec.rb (2.28 KB) umask_spec.rb MSP-Greg (Greg L), 01/20/2018 03:51 AM

Updated by MSP-Greg (Greg L) over 2 years ago

Eregon (Benoit Daloze),

Attached are three files (one patch, and two spec files from repo). Changes allow it to pass on MinGW. Rearranged things, not sure if that's appropriate (or done correctly)...

Thanks, Greg

#2

Updated by MSP-Greg (Greg L) over 2 years ago

  • ruby -v changed from ruby 2.6.0dev (2018-01-20 trunk 61964) [x64-mingw32] to ruby 2.6.0dev (2018-01-19 trunk 61950) [x64-mingw32]
  • Subject changed from 3 Spec failures building MinGW 2018-01-20 trunk 61964 to 3 Spec failures building MinGW 2018-01-19 trunk 61950
#3

Updated by MSP-Greg (Greg L) over 2 years ago

  • File deleted (chmod_umask.patch)
#4

Updated by MSP-Greg (Greg L) over 2 years ago

  • File deleted (umask_spec.rb)

Updated by Eregon (Benoit Daloze) over 2 years ago

  • Assignee set to Eregon (Benoit Daloze)

Thanks for the report, I'll take a look.
This spec looks rather hacky at first sight.

#8

Updated by Eregon (Benoit Daloze) over 2 years ago

  • Status changed from Open to Closed

Applied in changeset trunk|r62036.


Remove specs trying arbitrary values for chmod and umask

Updated by Eregon (Benoit Daloze) over 2 years ago

Thank you for the report and patches.

I decided to remove the specs trying arbitrary values for chmod/umask in r62036.
So much platform guards is usually a sign we are testing OS/libc-level stuff, which is not really the right thing for ruby/spec (we should test common real-world cases instead).

Also available in: Atom PDF